This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7151

setup: allow py3 install without env vars
ClosedPublic

Authored by Kwan on Oct 23 2019, 10:11 AM.

Details

Reviewers
mharbison72
Group Reviewers
hg-reviewers
Commits
rHGe7772b6b0a33: setup: allow py3 install without env vars
rHGc3e10f705a6c: setup: allow py3 install without env vars
rHG3733533c22a4: setup: allow py3 install without env vars
Summary

5.2 is the first release of Mercurial where py3 support is expected to be
widely used, therefore we should allow installing it without hoop-jumping.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Kwan created this revision.Oct 23 2019, 10:11 AM
dlax added a subscriber: dlax.Oct 23 2019, 10:16 AM
mharbison72 accepted this revision.Oct 23 2019, 2:36 PM
mharbison72 added a subscriber: mharbison72.

I guess you can backout a324f6a0cfd3 with this.

Kwan added a commit: rHG3733533c22a4: setup: allow py3 install without env vars.Oct 30 2019, 4:49 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG3733533c22a4: setup: allow py3 install without env vars (authored by Kwan). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msetup.py (80 lines)

Diff 17415

setup.py

# #
# This is the mercurial setup script. # This is the mercurial setup script.
# #
# 'python setup.py install', or # 'python setup.py install', or
# 'python setup.py --help' for more options # 'python setup.py --help' for more options
import os import os
supportedpy = '~= 2.7'
if os.environ.get('HGALLOWPYTHON3', ''):
# Mercurial will never work on Python 3 before 3.5 due to a lack # Mercurial will never work on Python 3 before 3.5 due to a lack
# of % formatting on bytestrings, and can't work on 3.6.0 or 3.6.1 # of % formatting on bytestrings, and can't work on 3.6.0 or 3.6.1
# due to a bug in % formatting in bytestrings. # due to a bug in % formatting in bytestrings.
# We cannot support Python 3.5.0, 3.5.1, 3.5.2 because of bug in # We cannot support Python 3.5.0, 3.5.1, 3.5.2 because of bug in
# codecs.escape_encode() where it raises SystemError on empty bytestring # codecs.escape_encode() where it raises SystemError on empty bytestring
# bug link: https://bugs.python.org/issue25270 # bug link: https://bugs.python.org/issue25270
#
# TODO: when we actually work on Python 3, use this string as the
# actual supportedpy string.
supportedpy = ','.join( supportedpy = ','.join(
[ [
'>=2.7', '>=2.7',
'!=3.0.*', '!=3.0.*',
'!=3.1.*', '!=3.1.*',
'!=3.2.*', '!=3.2.*',
'!=3.3.*', '!=3.3.*',
'!=3.4.*', '!=3.4.*',
'!=3.5.0', '!=3.5.0',
'!=3.5.1', '!=3.5.1',
'!=3.5.2', '!=3.5.2',
'!=3.6.0', '!=3.6.0',
'!=3.6.1', '!=3.6.1',
] ]
) )
import sys, platform import sys, platform
import sysconfig import sysconfig
if sys.version_info[0] >= 3: if sys.version_info[0] >= 3:
printf = eval('print') printf = eval('print')
libdir_escape = 'unicode_escape' libdir_escape = 'unicode_escape'
Python {py} detected. Python {py} detected.
{pip} {pip}
""".format( """.format(
py=sys.version_info, pip=pip_message py=sys.version_info, pip=pip_message
) )
printf(error, file=sys.stderr) printf(error, file=sys.stderr)
sys.exit(1) sys.exit(1)
# We don't yet officially support Python 3. But we want to allow developers to
# hack on. Detect and disallow running on Python 3 by default. But provide a
# backdoor to enable working on Python 3.
if sys.version_info[0] != 2:
badpython = True
# Allow Python 3 from source checkouts.
if os.path.isdir('.hg') or 'HGPYTHON3' in os.environ:
badpython = False
if badpython:
error = """
Python {py} detected.
Mercurial currently has beta support for Python 3 and use of Python 2.7 is
recommended for the best experience.
Please re-run with Python 2.7 for a faster, less buggy experience.
If you would like to beta test Mercurial with Python 3, this error can
be suppressed by defining the HGPYTHON3 environment variable when invoking
this command. No special environment variables or configuration changes are
necessary to run `hg` with Python 3.
See https://www.mercurial-scm.org/wiki/Python3 for more on Mercurial's
Python 3 support.
""".format(
py='.'.join('%d' % x for x in sys.version_info[0:2])
)
printf(error, file=sys.stderr)
sys.exit(1)
if sys.version_info[0] >= 3: if sys.version_info[0] >= 3:
DYLIB_SUFFIX = sysconfig.get_config_vars()['EXT_SUFFIX'] DYLIB_SUFFIX = sysconfig.get_config_vars()['EXT_SUFFIX']
else: else:
# deprecated in Python 3 # deprecated in Python 3
DYLIB_SUFFIX = sysconfig.get_config_vars()['SO'] DYLIB_SUFFIX = sysconfig.get_config_vars()['SO']
# Solaris Python packaging brain damage # Solaris Python packaging brain damage
try: try: