This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	indygreg	D7214 fsmonitor: normalize exception types to bytes
Closed	indygreg	D7213 fsmonitor: normalize clock value to bytes
Closed	indygreg	D7212 fsmonitor: use next() instead of .next()
Closed	indygreg	D7211 fsmonitor: normalize Watchman paths to bytes
Closed	indygreg	D7210 fsmonitor: handle unicode keys in tuples
Closed	indygreg	D7209 fsmonitor: make _hashignore compatible with Python 3
Closed	indygreg	D7208 fsmonitor: normalize hostname to bytes
Closed	indygreg	D7207 fsmonitor: access repo.root
Closed	indygreg	D7206 fsmonitor: coerce watchman exception to bytes
Closed	indygreg	D7205 fsmonitor: fix str/bytes mismatch when accessing watchman version
Closed	indygreg	D7204 fsmonitor: reapply b1f62cd39b5c
Closed	indygreg	D7203 fsmonitor: reapply dd35abc409ee
Closed	indygreg	D7202 fsmonitor: remove pywatchman from exclusion rule
Closed	indygreg	D7201 fsmonitor: refresh pywatchman with upstream

Diff 17501

	# Using the flag STARTF_USESHOWWINDOW to avoid this behavior.			# Using the flag STARTF_USESHOWWINDOW to avoid this behavior.
	startupinfo = subprocess.STARTUPINFO()			startupinfo = subprocess.STARTUPINFO()
	startupinfo.dwFlags \|= subprocess.STARTF_USESHOWWINDOW			startupinfo.dwFlags \|= subprocess.STARTF_USESHOWWINDOW
	args["startupinfo"] = startupinfo			args["startupinfo"] = startupinfo

	p = subprocess.Popen(cmd, **args)			p = subprocess.Popen(cmd, **args)

	except OSError as e:			except OSError as e:
	raise WatchmanError('"watchman" executable not in PATH (%s)', e)			raise WatchmanError('"watchman" executable not in PATH (%s)' % e)

	stdout, stderr = p.communicate()			stdout, stderr = p.communicate()
	exitcode = p.poll()			exitcode = p.poll()

	if exitcode:			if exitcode:
	raise WatchmanError("watchman exited with code %d" % exitcode)			raise WatchmanError("watchman exited with code %d" % exitcode)

	result = bser.loads(stdout)			result = bser.loads(stdout)