This is an archive of the discontinued Mercurial Phabricator instance.

obsmarker: track operation by default
ClosedPublic

Authored by martinvonz on Sep 15 2017, 2:00 PM.

Details

Summary

We added support for including the operation responsible for creating
the obsmarker in 3546a771e376 (obsolete: add operation metadata to
rebase/amend/histedit obsmarkers, 2017-05-09). However, soon
thereafter, in f432897a9f49 (obsmarker: add an experimental flag
controlling "operation" recording, 2017-05-20), it was hidden behind a
config that was off by default. It seems unlikely that people will
manually turn it on, and obsmarkers/evolution as a whole is still
experimental anyway, so let's turn on the tracking by default.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Sep 15 2017, 2:00 PM
quark accepted this revision.EditedSep 15 2017, 6:35 PM
quark added a subscriber: quark.

I think we do need this information recorded. Previous discussion someone mentioned that 10% increase in obsstore size is bad. But the current obsstore format has other stupid repetitive information like "user". So I won't blame this patch.

martinvonz updated this revision to Diff 1865.Sep 18 2017, 12:00 PM

Did you activated it at Facebook? Do you have some number on the size with and without it?

Did you activated it at Facebook? Do you have some number on the size with and without it?

Facebook has been using it since Apr 2016: https://bitbucket.org/facebook/hg-experimental/commits/a4165c954c665e3c85a80127df4943dd31b78297

The obsstore size is usually way smaller than hg-committed so it's not a concern yet.

We have zero user with the feature disabled. You can calculate the size yourself since the size of a marker is known.

durin42 accepted this revision.Sep 20 2017, 11:58 AM
This revision is now accepted and ready to land.Sep 20 2017, 11:58 AM
This revision was automatically updated to reflect the committed changes.