This is an archive of the discontinued Mercurial Phabricator instance.

templates: introduce a obsfateoperation() function
ClosedPublic

Authored by martinvonz on Sep 15 2017, 2:00 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Sep 15 2017, 2:00 PM
quark accepted this revision.Sep 15 2017, 6:41 PM
quark added a subscriber: quark.

I think this is a good step forward.

martinvonz updated this revision to Diff 1861.Sep 15 2017, 7:46 PM
lothiraldan added inline comments.
tests/test-obsmarker-template.t
20

Could you fix https://phab.mercurial-scm.org/D722 so we don't have this renaming here?

martinvonz marked an inline comment as done.Sep 18 2017, 12:00 PM
martinvonz updated this revision to Diff 1866.
martinvonz added inline comments.Sep 18 2017, 12:00 PM
tests/test-obsmarker-template.t
20

Oops, it wasn't supposed to be in D722 at all. Thanks for spotting that.

I'm +1 with "rewritten using amend as". I find it useful as a complement to the verb.

I'm -0 with "split using amend, rebase as". It find it harder to read and understand even if it brings some value.

+1 for changing the words. I think it should be just "split as ...." or "amend as ...." etc without the word "rewritten". People want the "rewritten" word could customize their own templates.

In D723#12507, @quark wrote:

+1 for changing the words. I think it should be just "split as ...." or "amend as ...." etc without the word "rewritten". People want the "rewritten" word could customize their own templates.

This is just a test case, do we really care that much? (I don't :-))

durin42 accepted this revision.Sep 20 2017, 11:58 AM
This revision is now accepted and ready to land.Sep 20 2017, 11:58 AM

This is just a test case, do we really care that much? (I don't :-))

No. I thought there is a default template. But there isn't.

This revision was automatically updated to reflect the committed changes.