Page MenuHomePhabricator

directaccess: add support to export and tests to demonstrate things
AbandonedPublic

Authored by pulkit on Sep 19 2017, 9:36 PM.

Details

Reviewers
durham
ryanmce
Group Reviewers
hg-reviewers
Summary

This patch adds the cmdtype attribute to export command which is a read only
command and adds test for accessing hidden commits using the same command.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Sep 19 2017, 9:36 PM
durham accepted this revision.Sep 26 2017, 8:20 AM
durham added a subscriber: durham.
durham added inline comments.
tests/test-directaccess.t
11

Do we need uncommit? It doesn't seem used.

64

I'm still not sure we want to support rev numbers. I think we definitely don't want to support them for write commands, even recoverable ones.

pulkit planned changes to this revision.Oct 6 2017, 5:16 PM
pulkit updated this revision to Diff 2598.Oct 11 2017, 3:11 PM
ryanmce requested changes to this revision.Oct 12 2017, 7:38 AM
ryanmce added a subscriber: ryanmce.
ryanmce added inline comments.
tests/test-directaccess.t
24–36

Why so many commits here? It seems to needlessly bloat the test.

64

This is showing the rev numbers are not supported, right?

This revision now requires changes to proceed.Oct 12 2017, 7:38 AM
pulkit added inline comments.Oct 12 2017, 1:30 PM
tests/test-directaccess.t
24–36

Okay will fix in next version.

64

Yes!

pulkit abandoned this revision.Oct 17 2017, 8:24 AM

Resend the series as D1140 - D1144.