Page MenuHomePhabricator

procutil: move mainfrozen() to new resourceutil.py
ClosedPublic

Authored by martinvonz on Nov 15 2019, 2:12 PM.

Details

Summary

The i18n module practically depends on procutil for mainfrozen() but
since procutil depends on i18n, it would be a circular dependency if
i18n depended directly on procutil. The cycle is currently resolved by
having the higher-level util module calculate the "datapath" and
inject it into i18n. Extracting mainfrozen() to a new module lets us
clean up the dependencies.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Nov 15 2019, 2:12 PM
indygreg accepted this revision.Nov 16 2019, 2:04 PM
indygreg added a subscriber: indygreg.

I'm not super thrilled about yet another module in the startup path. But the reasoning makes sense. We can always refactor later if the post resources world turns out to remove the circular dependency.

This revision is now accepted and ready to land.Nov 16 2019, 2:04 PM
This revision was automatically updated to reflect the committed changes.