Page MenuHomePhabricator

shelve: add the missing `create` parameter to the bundlerepo constructor
ClosedPublic

Authored by mharbison72 on Tue, Nov 19, 5:46 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Tue, Nov 19, 5:46 PM
dlax accepted this revision.Wed, Nov 20, 3:02 AM
dlax added a subscriber: dlax.

Good catch.

On the other hand, it's not clear to me what's the point of this "create" argument given bundlerepo.instance() will just use it to raise Abort if it is true.

In D7458#109743, @dlax wrote:

Good catch.
On the other hand, it's not clear to me what's the point of this "create" argument given bundlerepo.instance() will just use it to raise Abort if it is true.

I think it’s so that the factory method is the same for each repo type, though I didn’t verify that’s still the case. I am surprised that this parameter doesn’t default to False. See 386f04d6ecb3. But I didn’t know if changing the signature on stable would be ok, or if there was a valid reason for the current signature.

pulkit accepted this revision.Thu, Nov 21, 7:30 AM
This revision is now accepted and ready to land.Thu, Nov 21, 7:30 AM