This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7458

shelve: add the missing `create` parameter to the bundlerepo constructor
ClosedPublic

Authored by mharbison72 on Nov 19 2019, 5:46 PM.

Details

Reviewers
dlax
pulkit
Group Reviewers
hg-reviewers
Commits
rHG132470ee53fe: shelve: add the missing `create` parameter to the bundlerepo constructor
Summary

Caught by pytype.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

mharbison72 created this revision.Nov 19 2019, 5:46 PM
dlax accepted this revision.Nov 20 2019, 3:02 AM
dlax added a subscriber: dlax.

Good catch.

On the other hand, it's not clear to me what's the point of this "create" argument given bundlerepo.instance() will just use it to raise Abort if it is true.

mharbison72 added a comment.Nov 20 2019, 7:57 AM
In D7458#109743, @dlax wrote:

Good catch.
On the other hand, it's not clear to me what's the point of this "create" argument given bundlerepo.instance() will just use it to raise Abort if it is true.

I think it’s so that the factory method is the same for each repo type, though I didn’t verify that’s still the case. I am surprised that this parameter doesn’t default to False. See 386f04d6ecb3. But I didn’t know if changing the signature on stable would be ok, or if there was a valid reason for the current signature.

pulkit accepted this revision.Nov 21 2019, 7:30 AM
This revision is now accepted and ready to land.Nov 21 2019, 7:30 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/shelve.py (2 lines)

Diff 18247

mercurial/shelve.py

shelvectx = self.repo[shelverev] shelvectx = self.repo[shelverev]
return shelvectx return shelvectx
finally: finally:
fp.close() fp.close()
def bundlerepo(self): def bundlerepo(self):
path = self.vfs.join(self.fname) path = self.vfs.join(self.fname)
return bundlerepo.instance( return bundlerepo.instance(
self.repo.baseui, b'bundle://%s+%s' % (self.repo.root, path) self.repo.baseui, b'bundle://%s+%s' % (self.repo.root, path), False
) )
def writebundle(self, bases, node): def writebundle(self, bases, node):
cgversion = changegroup.safeversion(self.repo) cgversion = changegroup.safeversion(self.repo)
if cgversion == b'01': if cgversion == b'01':
btype = b'HG10BZ' btype = b'HG10BZ'
compression = None compression = None
else: else: