This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7498

localrepo: also fast past the parents of working copies parents
ClosedPublic

Authored by marmoute on Nov 22 2019, 4:21 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG5a012404503b: localrepo: also fast past the parents of working copies parents
Summary

There are a descent odds that their will be needed too. So we also cache and
fastpath them.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Nov 22 2019, 4:21 AM
marmoute updated this revision to Diff 18361.Nov 23 2019, 8:04 AM
marmoute updated this revision to Diff 18385.Nov 24 2019, 6:26 AM
Alphare updated this revision to Diff 19364.Jan 16 2020, 9:25 AM
pulkit accepted this revision.Jan 17 2020, 9:59 AM
pulkit added a subscriber: pulkit.

There are a descent odds that their will be needed too.

There are descent odds that they will be needed too.

made the above edit in flight.

This revision is now accepted and ready to land.Jan 17 2020, 9:59 AM

Revision Contents
Changeset List

Diff 19364

mercurial/localrepo.py

if rev is None: if rev is None:
# unknown working copy parent case: # unknown working copy parent case:
# #
# skip the fast path and let higher code deal with it # skip the fast path and let higher code deal with it
continue continue
pair = (rev, node) pair = (rev, node)
quick[rev] = pair quick[rev] = pair
quick[node] = pair quick[node] = pair
# also add the parents of the parents
for r in cl.parentrevs(rev):
if r == nullrev:
continue
n = cl.node(r)
pair = (r, n)
quick[r] = pair
quick[n] = pair
p1node = self.dirstate.p1() p1node = self.dirstate.p1()
if p1node != nullid: if p1node != nullid:
quick[b'.'] = quick[p1node] quick[b'.'] = quick[p1node]
return quick return quick
@unfilteredmethod @unfilteredmethod
def _quick_access_changeid_invalidate(self): def _quick_access_changeid_invalidate(self):
if '_quick_access_changeid_wc' in vars(self): if '_quick_access_changeid_wc' in vars(self):

tests/test-repo-filters-tiptoe.t

-c -c
+c1 +c1
diff -r c2932ca7786be30b67154d541a8764fae5532261 d diff -r c2932ca7786be30b67154d541a8764fae5532261 d
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 --- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/d Thu Jan 01 00:00:00 1970 +0000 +++ b/d Thu Jan 01 00:00:00 1970 +0000
@@ -0,0 +1,1 @@ @@ -0,0 +1,1 @@
+d +d
$ hg diff --change . $ hg diff --change .
debug.filters: computing revision filter for "visible"
diff -r 05293e5dd8d1ae4f84a8520a11c6f97cad26deca -r c2932ca7786be30b67154d541a8764fae5532261 c diff -r 05293e5dd8d1ae4f84a8520a11c6f97cad26deca -r c2932ca7786be30b67154d541a8764fae5532261 c
--- /dev/null Thu Jan 01 00:00:00 1970 +0000 --- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/c Thu Jan 01 00:00:00 1970 +0000 +++ b/c Thu Jan 01 00:00:00 1970 +0000
@@ -0,0 +1,1 @@ @@ -0,0 +1,1 @@
+c +c
diff -r 05293e5dd8d1ae4f84a8520a11c6f97cad26deca -r c2932ca7786be30b67154d541a8764fae5532261 z diff -r 05293e5dd8d1ae4f84a8520a11c6f97cad26deca -r c2932ca7786be30b67154d541a8764fae5532261 z
--- a/z Thu Jan 01 00:00:00 1970 +0000 --- a/z Thu Jan 01 00:00:00 1970 +0000
+++ b/z Thu Jan 01 00:00:00 1970 +0000 +++ b/z Thu Jan 01 00:00:00 1970 +0000
@@ -1,2 +1,3 @@ @@ -1,2 +1,3 @@
some line some line
in a in a
+file +file
exporting the current changeset exporting the current changeset
$ hg export $ hg export
exporting patch: exporting patch:
debug.filters: computing revision filter for "visible"
# HG changeset patch # HG changeset patch
# User test # User test
# Date 0 0 # Date 0 0
# Thu Jan 01 00:00:00 1970 +0000 # Thu Jan 01 00:00:00 1970 +0000
# Node ID c2932ca7786be30b67154d541a8764fae5532261 # Node ID c2932ca7786be30b67154d541a8764fae5532261
# Parent 05293e5dd8d1ae4f84a8520a11c6f97cad26deca # Parent 05293e5dd8d1ae4f84a8520a11c6f97cad26deca
c c