Page MenuHomePhabricator

phabricator: add a "phabstatus" template keyword
ClosedPublic

Authored by dlax on Fri, Nov 22, 11:00 AM.

Details

Summary

We add a "phabstatus" template keyword, returning an object with "url"
and "status" keys. This is quite similar to "phabreview" template
keyword, but it queries phabricator for each specified revision so it's
going to be slow (as compared to the "phabstatus" show view from
previous changeset).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dlax created this revision.Fri, Nov 22, 11:00 AM
dlax updated this revision to Diff 18316.Fri, Nov 22, 11:03 AM
dlax updated this revision to Diff 18321.Fri, Nov 22, 4:13 PM

I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there?

dlax added a comment.Sat, Nov 23, 11:45 AM
I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there?

Not that I am aware. Using this keyword on large revsets is indeed slow.

pulkit accepted this revision.Tue, Dec 10, 10:48 AM
This revision is now accepted and ready to land.Tue, Dec 10, 10:48 AM
dlax updated this revision to Diff 18590.Tue, Dec 10, 2:46 PM
This revision was automatically updated to reflect the committed changes.