This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7507

phabricator: add a "phabstatus" template keyword
ClosedPublic

Authored by dlax on Nov 22 2019, 11:00 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG79c0121220e3: phabricator: add a "phabstatus" template keyword
Summary

We add a "phabstatus" template keyword, returning an object with "url"
and "status" keys. This is quite similar to "phabreview" template
keyword, but it queries phabricator for each specified revision so it's
going to be slow (as compared to the "phabstatus" show view from
previous changeset).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dlax created this revision.Nov 22 2019, 11:00 AM
dlax updated this revision to Diff 18316.Nov 22 2019, 11:03 AM
dlax updated this revision to Diff 18321.Nov 22 2019, 4:13 PM
mharbison72 added a subscriber: mharbison72.Nov 23 2019, 11:23 AM

I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there?

dlax added a comment.Nov 23 2019, 11:45 AM
I only have a superficial understanding about how templates work, but I assume that there's no global pre-resolution step where a single query could be done and the results stuffed into the context or something, is there?

Not that I am aware. Using this keyword on large revsets is indeed slow.

pulkit accepted this revision.Dec 10 2019, 10:48 AM
This revision is now accepted and ready to land.Dec 10 2019, 10:48 AM
dlax updated this revision to Diff 18590.Dec 10 2019, 2:46 PM
dlax added a commit: rHG79c0121220e3: phabricator: add a "phabstatus" template keyword.Dec 11 2019, 6:54 AM
Closed by commit rHG79c0121220e3: phabricator: add a "phabstatus" template keyword (authored by dlax). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (22 lines)

Diff 18604

hgext/phabricator.py

if not url.endswith(b'/'): if not url.endswith(b'/'):
url += b'/' url += b'/'
url += t url += t
return templateutil.hybriddict({b'url': url, b'id': t,}) return templateutil.hybriddict({b'url': url, b'id': t,})
return None return None
@eh.templatekeyword(b'phabstatus', requires={b'ctx', b'repo', b'ui'})
def template_status(context, mapping):
""":phabstatus: String. Status of Phabricator differential.
"""
ctx = context.resource(mapping, b'ctx')
repo = context.resource(mapping, b'repo')
ui = context.resource(mapping, b'ui')
rev = ctx.rev()
try:
drevid = getdrevmap(repo, [rev])[rev]
except KeyError:
return None
drevs = callconduit(ui, b'differential.query', {b'ids': [drevid]})
for drev in drevs:
if int(drev[b'id']) == drevid:
return templateutil.hybriddict(
{b'url': drev[b'uri'], b'status': drev[b'statusName'],}
)
return None
@show.showview(b'phabstatus', csettopic=b'work') @show.showview(b'phabstatus', csettopic=b'work')
def phabstatusshowview(ui, repo, displayer): def phabstatusshowview(ui, repo, displayer):
"""Phabricator differiential status""" """Phabricator differiential status"""
revs = repo.revs('sort(_underway(), topo)') revs = repo.revs('sort(_underway(), topo)')
drevmap = getdrevmap(repo, revs) drevmap = getdrevmap(repo, revs)
unknownrevs, drevids, revsbydrevid = [], set([]), {} unknownrevs, drevids, revsbydrevid = [], set([]), {}
for rev, drevid in pycompat.iteritems(drevmap): for rev, drevid in pycompat.iteritems(drevmap):
if drevid is not None: if drevid is not None: