Page MenuHomePhabricator

rust-matchers: add support for `exactmatcher` in `dirstate.status`
ClosedPublic

Authored by Alphare on Nov 29 2019, 1:22 PM.

Details

Summary

exactmatcher is the name in the Python implementation and corresponds to
FileMatcher in Rust.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Nov 29 2019, 1:22 PM

Did you mean s/explicitmatcher/exactmatcher/ in the description? Also, I thought you called it FileMatcher instead. What's the difference?

Yes, I meant exactmatcher indeed.
FileMatcher is meant for the Rust side of things, I do not intend to rename it in Python because it is a minor change that would make a lot of noise for bikeshedding. Do you think that would be a good idea?

Alphare retitled this revision from rust-matchers: add support for `explicitmatcher` in `dirstate.status` to rust-matchers: add support for `exactmatcher` in `dirstate.status`.Dec 12 2019, 10:40 AM
Alphare edited the summary of this revision. (Show Details)
Alphare updated this revision to Diff 18637.
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.