Page MenuHomePhabricator

rust-dirstatemap: remove additional lookup in dirstate.matches
ClosedPublic

Authored by Alphare on Oct 16 2019, 9:48 AM.

Details

Summary

We use the same trick as the Python implementation

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Oct 16 2019, 9:48 AM
Alphare updated this revision to Diff 18041.Nov 12 2019, 5:03 AM

What's up on this? It appears to have been

x  29641ceacf8c
|    pruned using prune by Martin von Zweigbergk <martinvonz@google.com> (Wed Dec 11 10:48:08 2019 -0800)

What's up on this? It appears to have been

x  29641ceacf8c
|    pruned using prune by Martin von Zweigbergk <martinvonz@google.com> (Wed Dec 11 10:48:08 2019 -0800)

That's probably because I queued some version of it and then decided to not queue it (I had comments on the parent).

@Alphare so what should we do of this patch ?

@Alphare so what should we do of this patch ?

IMO it should still be valid, it's harmless at best. I don't remember having strong performance numbers. Now that most of the status is done in Rust, it should matter less, even though it could still help shave off a few milliseconds.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.