Page MenuHomePhabricator

tests: cover revision conversion logic in githelp tests
ClosedPublic

Authored by dlax on Mon, Dec 2, 4:22 AM.

Details

Summary

There was no test involving actual conversion of option values when they
contain a git revision name (to be converted as a hg one by
hgext.githelp.convert()). Adding one. This test would fail on Python 3
without https://phab.mercurial-scm.org/D7537.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dlax created this revision.Mon, Dec 2, 4:22 AM
pulkit accepted this revision.Mon, Dec 2, 10:07 AM
This revision is now accepted and ready to land.Mon, Dec 2, 10:07 AM
mharbison72 accepted this revision.Mon, Dec 2, 12:44 PM
mharbison72 added a subscriber: mharbison72.
mharbison72 added inline comments.
tests/test-githelp.t
269

Not a problem with this change, but it doesn't look like commit has a -M option.

This revision was automatically updated to reflect the committed changes.