Page MenuHomePhabricator

repair: fix an `isinstance(nodelist, str)` check for py3
ClosedPublic

Authored by mharbison72 on Sat, Nov 30, 12:09 PM.

Details

Summary

All of the callers appear to pass a list, so this doesn't fix anything in core
hg. But maybe out of tree extensions use this shortcut.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Sat, Nov 30, 12:09 PM
dlax accepted this revision.Sun, Dec 1, 4:49 AM
dlax added a subscriber: dlax.

All these API where one can pass either a list of "things" or just one "thing" is kind of ugly. We should only handle the list case, I think.

pulkit accepted this revision.Mon, Dec 2, 10:05 AM
This revision is now accepted and ready to land.Mon, Dec 2, 10:05 AM