( )⚙ D7533 repair: fix an `isinstance(nodelist, str)` check for py3

This is an archive of the discontinued Mercurial Phabricator instance.

repair: fix an `isinstance(nodelist, str)` check for py3

Authored by mharbison72 on Nov 30 2019, 12:09 PM.



All of the callers appear to pass a list, so this doesn't fix anything in core
hg. But maybe out of tree extensions use this shortcut.

Diff Detail

rHG Mercurial
Lint Skipped
Unit Tests Skipped

Event Timeline

mharbison72 created this revision.Nov 30 2019, 12:09 PM
dlax accepted this revision.Dec 1 2019, 4:49 AM
dlax added a subscriber: dlax.

All these API where one can pass either a list of "things" or just one "thing" is kind of ugly. We should only handle the list case, I think.

pulkit accepted this revision.Dec 2 2019, 10:05 AM
This revision is now accepted and ready to land.Dec 2 2019, 10:05 AM