This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7607

phabricator: add the "Changes Planned" status name
ClosedPublic

Authored by mharbison72 on Dec 11 2019, 11:24 PM.

Details

Reviewers
dlax
pulkit
Group Reviewers
hg-reviewers
Commits
rHG74ec6ca0eb75: phabricator: add the "Changes Planned" status name
Summary

I noticed this when coloring the status output. But it looks like status names
are also used in the pseudo revset language as well, and abort when parsing a
name not in this list.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 11 2019, 11:24 PM
dlax accepted this revision.Dec 12 2019, 2:52 AM
pulkit accepted this revision.Dec 12 2019, 7:20 AM
This revision is now accepted and ready to land.Dec 12 2019, 7:20 AM
mharbison72 added a commit: rHG74ec6ca0eb75: phabricator: add the "Changes Planned" status name.Dec 12 2019, 7:52 AM
Closed by commit rHG74ec6ca0eb75: phabricator: add the "Changes Planned" status name (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (1 line)

Diff 18628

hgext/phabricator.py

_knownstatusnames = { _knownstatusnames = {
b'accepted', b'accepted',
b'needsreview', b'needsreview',
b'needsrevision', b'needsrevision',
b'closed', b'closed',
b'abandoned', b'abandoned',
b'changesplanned',
} }
def _getstatusname(drev): def _getstatusname(drev):
"""get normalized status name from a Differential Revision""" """get normalized status name from a Differential Revision"""
return drev[b'statusName'].replace(b' ', b'').lower() return drev[b'statusName'].replace(b' ', b'').lower()