It was failing with "OSError: [Errno 13] Permission denied:
'/root/sub'". It has been failing since 8b1a9ba375e5 (match: make sure
root argument is always an absolute path (API), 2019-12-13). I don't
know why I didn't notice it before sending that patch.
Details
Details
- Reviewers
marmoute mharbison72 pulkit - Group Reviewers
hg-reviewers - Commits
- rHGd9d78e70149a: tests: fix failing doctest in match.py by adding dummy auditor
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Oddly, it's not an issue on Windows. No idea why that's the case. What's the stacktrace look like?
Comment Actions
+********************************************************************** +File "/usr/local/google/home/martinvonz/hg/mercurial/match.py", line 948, in mercurial.match.subdirmatcher +Failed example: + m1 = match(util.localpath(b'/root'), b'', [b'a.txt', b'sub/b.txt']) +Exception raised: + Traceback (most recent call last): + File "/usr/lib/python2.7/doctest.py", line 1315, in __run + compileflags, 1) in test.globs + File "<doctest mercurial.match.subdirmatcher[1]>", line 1, in <module> + m1 = match(util.localpath(b'/root'), b'', [b'a.txt', b'sub/b.txt']) + File "/usr/local/google/home/martinvonz/hg/mercurial/match.py", line 257, in match + kindpats = normalize(patterns, default, root, cwd, auditor, warn) + File "/usr/local/google/home/martinvonz/hg/mercurial/match.py", line 326, in _donormalize + pat = pathutil.canonpath(root, cwd, pat, auditor=auditor) + File "/usr/local/google/home/martinvonz/hg/mercurial/pathutil.py", line 207, in canonpath + auditor(name) + File "/usr/local/google/home/martinvonz/hg/mercurial/pathutil.py", line 112, in __call__ + self._checkfs(prefix, path) + File "/usr/local/google/home/martinvonz/hg/mercurial/pathutil.py", line 125, in _checkfs + st = os.lstat(curpath) + OSError: [Errno 13] Permission denied: '/root/sub' +**********************************************************************
Comment Actions
OK, thanks. We hit that path on Windows, so it must be something about the os.lstat implementation that differs.