This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7737

ancestor: drop another unused variable assignment
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 4:16 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG68b09ebf1c13: ancestor: drop another unused variable assignment
Summary

Also caught by PyCharm. The only time this is used is immediately after another
assignment below this.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 27 2019, 4:16 PM
mharbison72 added a commit: rHG68b09ebf1c13: ancestor: drop another unused variable assignment.Dec 27 2019, 5:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG68b09ebf1c13: ancestor: drop another unused variable assignment (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/ancestor.py (4 lines)

Diff 18968

mercurial/ancestor.py

dv = depth[v] dv = depth[v]
if dv == 0: if dv == 0:
continue continue
sv = seen[v] sv = seen[v]
for p in pfunc(v): for p in pfunc(v):
if p == nullrev: if p == nullrev:
continue continue
dp = depth[p] dp = depth[p]
nsp = sp = seen[p] sp = seen[p]
if dp <= dv: if dp <= dv:
depth[p] = dv + 1 depth[p] = dv + 1
if sp != sv: if sp != sv:
interesting[sv] += 1 interesting[sv] += 1
nsp = seen[p] = sv seen[p] = sv
if sp: if sp:
interesting[sp] -= 1 interesting[sp] -= 1
if interesting[sp] == 0: if interesting[sp] == 0:
del interesting[sp] del interesting[sp]
elif dv == dp - 1: elif dv == dp - 1:
nsp = sp | sv nsp = sp | sv
if nsp == sp: if nsp == sp:
continue continue