This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7744

perf: drop an unused variable assignment
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 4:17 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG943e34522b37: perf: drop an unused variable assignment
Summary

Caught by PyCharm. A different formatter is created below in _displaystats().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 27 2019, 4:17 PM
mharbison72 added a commit: rHG943e34522b37: perf: drop an unused variable assignment.Dec 27 2019, 5:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG943e34522b37: perf: drop an unused variable assignment (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (3 lines)

Diff 18975

contrib/perf.py

fm.data(**data) fm.data(**data)
out = data.copy() out = data.copy()
out['source'] = fm.hexfunc(base.node()) out['source'] = fm.hexfunc(base.node())
out['destination'] = fm.hexfunc(parent.node()) out['destination'] = fm.hexfunc(parent.node())
fm.plain(output % out) fm.plain(output % out)
fm.end() fm.end()
if dostats: if dostats:
# use a second formatter because the data are quite different, not sure
# how it flies with the templater.
fm = ui.formatter(b'perf', opts)
entries = [ entries = [
('nbrevs', 'number of revision covered'), ('nbrevs', 'number of revision covered'),
('nbmissingfiles', 'number of missing files at head'), ('nbmissingfiles', 'number of missing files at head'),
] ]
if dotiming: if dotiming:
entries.append(('nbrenames', 'renamed files')) entries.append(('nbrenames', 'renamed files'))
entries.append(('time', 'time')) entries.append(('time', 'time'))
_displaystats(ui, opts, entries, alldata) _displaystats(ui, opts, entries, alldata)