This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7746

rebase: drop an unused variable assignment
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 4:17 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHGbd88407edc0e: rebase: drop an unused variable assignment
Summary

Caught by PyCharm.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 27 2019, 4:17 PM
mharbison72 added a commit: rHGbd88407edc0e: rebase: drop an unused variable assignment.Dec 27 2019, 5:02 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGbd88407edc0e: rebase: drop an unused variable assignment (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/rebase.py (1 line)

Diff 18977

hgext/rebase.py

_( _(
b"warning: new changesets detected on " b"warning: new changesets detected on "
b"destination branch, can't strip\n" b"destination branch, can't strip\n"
) )
) )
cleanup = False cleanup = False
if cleanup: if cleanup:
shouldupdate = False
if rebased: if rebased:
strippoints = [ strippoints = [
c.node() for c in repo.set(b'roots(%ld)', rebased) c.node() for c in repo.set(b'roots(%ld)', rebased)
] ]
updateifonnodes = set(rebased) updateifonnodes = set(rebased)
updateifonnodes.update(self.destmap.values()) updateifonnodes.update(self.destmap.values())
updateifonnodes.add(self.originalwd) updateifonnodes.add(self.originalwd)