This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7739

changegroup: drop an unused variable assignment
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 4:16 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6d2b5c4efdae: changegroup: drop an unused variable assignment
Summary

Caught by PyCharm. The variable is assigned again below before it is used.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 27 2019, 4:16 PM
mharbison72 added a commit: rHG6d2b5c4efdae: changegroup: drop an unused variable assignment.Dec 27 2019, 5:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG6d2b5c4efdae: changegroup: drop an unused variable assignment (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/changegroup.py (2 lines)

Diff 18970

mercurial/changegroup.py

def csmap(x): def csmap(x):
repo.ui.debug(b"add changeset %s\n" % short(x)) repo.ui.debug(b"add changeset %s\n" % short(x))
return len(cl) return len(cl)
def revmap(x): def revmap(x):
return cl.rev(x) return cl.rev(x)
changesets = 0
try: try:
# The transaction may already carry source information. In this # The transaction may already carry source information. In this
# case we use the top level data. We overwrite the argument # case we use the top level data. We overwrite the argument
# because we need to use the top level value (if they exist) # because we need to use the top level value (if they exist)
# in this function. # in this function.
srctype = tr.hookargs.setdefault(b'source', srctype) srctype = tr.hookargs.setdefault(b'source', srctype)
tr.hookargs.setdefault(b'url', url) tr.hookargs.setdefault(b'url', url)
repo.hook( repo.hook(