This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7756

fsmonitor: drop an unused local variable assignment
ClosedPublic

Authored by mharbison72 on Dec 27 2019, 8:29 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGc8a51a90929b: fsmonitor: drop an unused local variable assignment
Summary

Flagged by PyCharm.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 27 2019, 8:29 PM
pulkit accepted this revision.Dec 30 2019, 7:48 AM
This revision is now accepted and ready to land.Dec 30 2019, 7:48 AM
mharbison72 added a commit: rHGc8a51a90929b: fsmonitor: drop an unused local variable assignment.Dec 30 2019, 8:32 AM
Closed by commit rHGc8a51a90929b: fsmonitor: drop an unused local variable assignment (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 19016

hgext/fsmonitor/pywatchman/pybser.py

else: else:
raise ValueError( raise ValueError(
"unhandled bser opcode 0x%s" "unhandled bser opcode 0x%s"
% binascii.hexlify(val_type).decode("ascii") % binascii.hexlify(val_type).decode("ascii")
) )
def _pdu_info_helper(buf): def _pdu_info_helper(buf):
bser_version = -1
if buf[0:2] == EMPTY_HEADER[0:2]: if buf[0:2] == EMPTY_HEADER[0:2]:
bser_version = 1 bser_version = 1
bser_capabilities = 0 bser_capabilities = 0
expected_len, pos2 = Bunser.unser_int(buf, 2) expected_len, pos2 = Bunser.unser_int(buf, 2)
elif buf[0:2] == EMPTY_HEADER_V2[0:2]: elif buf[0:2] == EMPTY_HEADER_V2[0:2]:
if len(buf) < 8: if len(buf) < 8:
raise ValueError("Invalid BSER header") raise ValueError("Invalid BSER header")
bser_version = 2 bser_version = 2