This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	mharbison72	D7761 hgweb: delete a local variable instead of setting to `None`
Closed	mharbison72	D7760 tests: drop unused local variable assignments in linelog
Closed	mharbison72	D7759 ui: delete local variables instead of setting to `None`
Closed	mharbison72	D7758 tests: drop unused local variable assignments in remotefilelog
Closed	mharbison72	D7757 fastannotate: drop unused local variable assignments
Closed	mharbison72	D7756 fsmonitor: drop an unused local variable assignment
Closed	mharbison72	D7755 mq: drop an unused variable assignment
Closed	mharbison72	D7754 hgweb: delete local variable instead of setting it to `None`
Closed	mharbison72	D7753 annotate: avoid using a list comprehension to fill a list with fixed values
Closed	mharbison72	D7752 fsmonitor: drop an unused local variable
Closed	mharbison72	D7751 absorb: avoid using a list comprehension to fill a list with fixed values

Diff 18989

	with open(path, 'rb') as f:			with open(path, 'rb') as f:
	raw = f.read()			raw = f.read()
	raw = struct.pack('!B', 255) + raw[1:]			raw = struct.pack('!B', 255) + raw[1:]
	os.chmod(path, os.stat(path).st_mode \| stat.S_IWRITE)			os.chmod(path, os.stat(path).st_mode \| stat.S_IWRITE)
	with open(path, 'wb+') as f:			with open(path, 'wb+') as f:
	f.write(raw)			f.write(raw)

	try:			try:
	pack = self.datapackreader(pack.path)			self.datapackreader(pack.path)
	self.assertTrue(False, "bad version number should have thrown")			self.assertTrue(False, "bad version number should have thrown")
	except RuntimeError:			except RuntimeError:
	pass			pass

	def testMissingDeltabase(self):			def testMissingDeltabase(self):
	fakenode = self.getFakeHash()			fakenode = self.getFakeHash()
	revisions = [(b"filename", fakenode, self.getFakeHash(), b"content")]			revisions = [(b"filename", fakenode, self.getFakeHash(), b"content")]
	pack = self.createPack(revisions)			pack = self.createPack(revisions)

	with open(path, 'rb') as f:			with open(path, 'rb') as f:
	raw = f.read()			raw = f.read()
	raw = struct.pack('!B', 255) + raw[1:]			raw = struct.pack('!B', 255) + raw[1:]
	os.chmod(path, os.stat(path).st_mode \| stat.S_IWRITE)			os.chmod(path, os.stat(path).st_mode \| stat.S_IWRITE)
	with open(path, 'wb+') as f:			with open(path, 'wb+') as f:
	f.write(raw)			f.write(raw)

	try:			try:
	pack = historypack.historypack(pack.path)			historypack.historypack(pack.path)
	self.assertTrue(False, "bad version number should have thrown")			self.assertTrue(False, "bad version number should have thrown")
	except RuntimeError:			except RuntimeError:
	pass			pass

	def testLargePack(self):			def testLargePack(self):
	"""Test creating and reading from a large pack with over X entries.			"""Test creating and reading from a large pack with over X entries.
	This causes it to use a 2^16 fanout table instead."""			This causes it to use a 2^16 fanout table instead."""
	total = basepack.SMALLFANOUTCUTOFF + 1			total = basepack.SMALLFANOUTCUTOFF + 1