This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7946

py3: add extra traceback line present on Python 3.8
ClosedPublic

Authored by indygreg on Jan 18 2020, 4:18 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG51fb449bd1a2: py3: add extra traceback line present on Python 3.8
rHG1bb24b1ef368: py3: add extra traceback line present on Python 3.8
Summary

I'm not sure why Python 3.8 is outputting this line. It
appears to be a change in behavior of formatting tracebacks on
Python 3.8. So let's add it to expected output.

With this change, test-hook.t now passes on Python 3.8.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mtests/test-hook.t (2 lines)

Diff 19450

tests/test-hook.t

ModuleNotFoundError: No module named 'hgext_syntaxerror' (py36 !) ModuleNotFoundError: No module named 'hgext_syntaxerror' (py36 !)
Traceback (most recent call last): Traceback (most recent call last):
SyntaxError: * (glob) (py3 !) SyntaxError: * (glob) (py3 !)
Traceback (most recent call last): (py3 !) Traceback (most recent call last): (py3 !)
ImportError: No module named 'hgext_syntaxerror' (py3 no-py36 !) ImportError: No module named 'hgext_syntaxerror' (py3 no-py36 !)
ModuleNotFoundError: No module named 'hgext_syntaxerror' (py36 !) ModuleNotFoundError: No module named 'hgext_syntaxerror' (py36 !)
Traceback (most recent call last): (py3 !) Traceback (most recent call last): (py3 !)
HookLoadError: preoutgoing.syntaxerror hook is invalid: import of "syntaxerror" failed (no-py3 !) HookLoadError: preoutgoing.syntaxerror hook is invalid: import of "syntaxerror" failed (no-py3 !)
raise error.HookLoadError( (py38 !)
mercurial.error.HookLoadError: preoutgoing.syntaxerror hook is invalid: import of "syntaxerror" failed (py3 !) mercurial.error.HookLoadError: preoutgoing.syntaxerror hook is invalid: import of "syntaxerror" failed (py3 !)
abort: preoutgoing.syntaxerror hook is invalid: import of "syntaxerror" failed abort: preoutgoing.syntaxerror hook is invalid: import of "syntaxerror" failed
$ echo '[hooks]' > ../a/.hg/hgrc $ echo '[hooks]' > ../a/.hg/hgrc
$ echo 'preoutgoing.pass = python:hooktests.passhook' >> ../a/.hg/hgrc $ echo 'preoutgoing.pass = python:hooktests.passhook' >> ../a/.hg/hgrc
$ hg pull ../a $ hg pull ../a
pulling from ../a pulling from ../a
searching for changes searching for changes
ImportError: No module named 'somebogusmodule' (py3 no-py36 !) ImportError: No module named 'somebogusmodule' (py3 no-py36 !)
ModuleNotFoundError: No module named 'somebogusmodule' (py36 !) ModuleNotFoundError: No module named 'somebogusmodule' (py36 !)
Traceback (most recent call last): Traceback (most recent call last):
ImportError: No module named hgext_importfail (no-py3 !) ImportError: No module named hgext_importfail (no-py3 !)
ImportError: No module named 'hgext_importfail' (py3 no-py36 !) ImportError: No module named 'hgext_importfail' (py3 no-py36 !)
ModuleNotFoundError: No module named 'hgext_importfail' (py36 !) ModuleNotFoundError: No module named 'hgext_importfail' (py36 !)
Traceback (most recent call last): Traceback (most recent call last):
HookLoadError: precommit.importfail hook is invalid: import of "importfail" failed (no-py3 !) HookLoadError: precommit.importfail hook is invalid: import of "importfail" failed (no-py3 !)
raise error.HookLoadError( (py38 !)
mercurial.error.HookLoadError: precommit.importfail hook is invalid: import of "importfail" failed (py3 !) mercurial.error.HookLoadError: precommit.importfail hook is invalid: import of "importfail" failed (py3 !)
abort: precommit.importfail hook is invalid: import of "importfail" failed abort: precommit.importfail hook is invalid: import of "importfail" failed
Issue1827: Hooks Update & Commit not completely post operation Issue1827: Hooks Update & Commit not completely post operation
commit and update hooks should run after command completion. The largefiles commit and update hooks should run after command completion. The largefiles
use demonstrates a recursive wlock, showing the hook doesn't run until the use demonstrates a recursive wlock, showing the hook doesn't run until the
final release (and dirstate flush). final release (and dirstate flush).