http://urlgrabber.baseurl.org/ is available on both corp and prod, without
additional dependencies specified, and a simple API.
Details
- Reviewers
quark - Group Reviewers
Restricted Project - Commits
- rFBHGX579b9cd5f521: phabricator: switch to urlgrabber for phabricator communications
Diff Detail
- Repository
- rFBHGX Facebook Mercurial Extensions
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Does this extension have tests? If so, we probably want to add python -c 'import ...' || exit 80 to skip the test if the library does not exist.
Besides, since this is a foreign extension. I guess you may need to change tests/modcheck.py.
Yes, but they mock out all code that calls urlgrabber. We should probably change that to mocking just that module; the current setup won't let us test D800 for example.
Besides, since this is a foreign extension. I guess you may need to change tests/modcheck.py.
I'll take a look.
That sounds good enough. I think it's fine as-is. Improving testing seems a lot of work without much benefit in this case.
Besides, since this is a foreign extension. I guess you may need to change tests/modcheck.py.
I'll take a look.
You can use arc unit which will load modcheck.py to see if it causes problems. If all external code gets wrapped, in theory it's good because the external library won't get a chance to be imported.
This breaks hg ssl on Windows. We can't just install dependencies there, we need to bundle them.