( )⚙ D8138 phabricator: add a config knob to create obsolete markers when importing

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8138

phabricator: add a config knob to create obsolete markers when importing
ClosedPublic

Authored by mharbison72 on Feb 20 2020, 8:10 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGf10055b099b3: phabricator: add a config knob to create obsolete markers when importing
Summary

This too can get a tristate switch if desired. But if so, that needs to happen
by having evolve add the option.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Feb 20 2020, 8:10 PM
mharbison72 updated this revision to Diff 20428.Mar 3 2020, 1:25 PM
mharbison72 updated this revision to Diff 20452.Mar 4 2020, 9:57 AM
durin42 accepted this revision.Mar 4 2020, 1:57 PM
durin42 added a subscriber: durin42.

I'm on the fence about this, but overall it seems fine.

This revision is now accepted and ready to land.Mar 4 2020, 1:57 PM

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (5 lines)

Diff 20787

hgext/phabricator.py

b'phabricator', b'url', default=None, b'phabricator', b'url', default=None,
) )
eh.configitem( eh.configitem(
b'phabsend', b'confirm', default=False, b'phabsend', b'confirm', default=False,
) )
eh.configitem( eh.configitem(
b'phabimport', b'secret', default=False, b'phabimport', b'secret', default=False,
) )
eh.configitem(
b'phabimport', b'obsolete', default=False,
)
colortable = { colortable = {
b'phabricator.action.created': b'green', b'phabricator.action.created': b'green',
b'phabricator.action.skipped': b'magenta', b'phabricator.action.skipped': b'magenta',
b'phabricator.action.updated': b'magenta', b'phabricator.action.updated': b'magenta',
b'phabricator.desc': b'', b'phabricator.desc': b'',
b'phabricator.drev': b'bold', b'phabricator.drev': b'bold',
b'phabricator.node': b'', b'phabricator.node': b'',
# Mandatory default values, synced with commands.import # Mandatory default values, synced with commands.import
opts[b'strip'] = 1 opts[b'strip'] = 1
opts[b'prefix'] = b'' opts[b'prefix'] = b''
# Evolve 9.3.0 assumes this key is present in cmdutil.tryimportone() # Evolve 9.3.0 assumes this key is present in cmdutil.tryimportone()
opts[b'obsolete'] = False opts[b'obsolete'] = False
if ui.configbool(b'phabimport', b'secret'): if ui.configbool(b'phabimport', b'secret'):
opts[b'secret'] = True opts[b'secret'] = True
if ui.configbool(b'phabimport', b'obsolete'):
opts[b'obsolete'] = True # Handled by evolve wrapping tryimportone()
def _write(patches): def _write(patches):
parents = repo[None].parents() parents = repo[None].parents()
with repo.wlock(), repo.lock(), repo.transaction(b'phabimport'): with repo.wlock(), repo.lock(), repo.transaction(b'phabimport'):
for drev, contents in patches: for drev, contents in patches:
ui.status(_(b'applying patch from D%s\n') % drev) ui.status(_(b'applying patch from D%s\n') % drev)