Page MenuHomePhabricator

phabricator: allow multiple DREVSPEC args to phabread|phabimport|phabupdate
ClosedPublic

Authored by mharbison72 on Thu, Mar 5, 11:42 AM.

Details

Summary

Per Augie's request. Like regular revsets, the result is the union of all given
specs. Unlike regular revsets, these don't resolve in parent -> child order,
and should be specified as such on the command line.

This change invalidated a previous test using an empty hg phabread, so it has
been switched to hg debugcallconduit to preserve that coverage.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Thu, Mar 5, 11:42 AM
marmoute accepted this revision.Thu, Mar 19, 7:25 PM
marmoute added a subscriber: marmoute.

The code change seems simple and covered by tests.

pulkit accepted this revision.Fri, Mar 20, 3:44 AM
This revision is now accepted and ready to land.Fri, Mar 20, 3:44 AM
pulkit requested changes to this revision.Fri, Mar 20, 3:53 AM

This one fails to apply on current tip of default. Can you rebase and resend?

This revision now requires changes to proceed.Fri, Mar 20, 3:53 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.