This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8174

nodemap: refresh the persistent data on nodemap creation
ClosedPublic

Authored by marmoute on Feb 27 2020, 4:09 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG87b327de772c: nodemap: refresh the persistent data on nodemap creation
Summary

The logic to read the data and validate the docket are still in python, so we
need to "help" whatever compiled code live in the index to refresh it.

Otherwise clearing the cache could lead to an expensive full recomputation and
disk update even when the persisted data are still valid.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Feb 27 2020, 4:09 AM
marmoute updated this revision to Diff 20576.Mar 6 2020, 6:35 PM

eventless rebase past D8255

marmoute updated this revision to Diff 20677.Mar 10 2020, 9:34 PM

rebase above latest default up to landed-D8182

marmoute added a commit: rHG87b327de772c: nodemap: refresh the persistent data on nodemap creation.Mar 11 2020, 11:41 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG87b327de772c: nodemap: refresh the persistent data on nodemap creation (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revlog.py (13 lines)

Diff 20689

mercurial/revlog.py

else: else:
nodemaputil.setup_persistent_nodemap(transaction, self) nodemaputil.setup_persistent_nodemap(transaction, self)
def clearcaches(self): def clearcaches(self):
self._revisioncache = None self._revisioncache = None
self._chainbasecache.clear() self._chainbasecache.clear()
self._chunkcache = (0, b'') self._chunkcache = (0, b'')
self._pcache = {} self._pcache = {}
self._nodemap_docket = None
self.index.clearcaches() self.index.clearcaches()
# The python code is the one responsible for validating the docket, we
# end up having to refresh it here.
use_nodemap = (
not self._inline
and self.nodemap_file is not None
and util.safehasattr(self.index, 'update_nodemap_data')
)
if use_nodemap:
nodemap_data = nodemaputil.persisted_data(self)
if nodemap_data is not None:
self._nodemap_docket = nodemap_data[0]
self.index.update_nodemap_data(*nodemap_data)
def rev(self, node): def rev(self, node):
try: try:
return self.index.rev(node) return self.index.rev(node)
except TypeError: except TypeError:
raise raise
except error.RevlogError: except error.RevlogError:
# parsers.c radix tree lookup failed # parsers.c radix tree lookup failed