This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8161

rust-nodemap: also clear Rust data in `clearcaches`
ClosedPublic

Authored by Alphare on Feb 26 2020, 12:37 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGcadcc8c20860: rust-nodemap: also clear Rust data in `clearcaches`

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Feb 26 2020, 12:37 PM
marmoute updated this revision to Diff 20380.Feb 28 2020, 1:54 PM
Alphare updated this revision to Diff 20660.Mar 10 2020, 6:52 AM
gracinet added a commit: rHGcadcc8c20860: rust-nodemap: also clear Rust data in `clearcaches`.Mar 11 2020, 11:42 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGcadcc8c20860: rust-nodemap: also clear Rust data in `clearcaches` (authored by gracinet). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-cpython/src/revlog.rs (8 lines)

Diff 20699

rust/hg-cpython/src/revlog.rs

self.call_cindex(py, "ancestors", args, kw) self.call_cindex(py, "ancestors", args, kw)
} }
/// return the heads of the common ancestors of the given revs /// return the heads of the common ancestors of the given revs
def commonancestorsheads(&self, *args, **kw) -> PyResult<PyObject> { def commonancestorsheads(&self, *args, **kw) -> PyResult<PyObject> {
self.call_cindex(py, "commonancestorsheads", args, kw) self.call_cindex(py, "commonancestorsheads", args, kw)
} }
/// clear the index caches /// Clear the index caches and inner py_class data.
/// It is Python's responsibility to call `update_nodemap_data` again.
def clearcaches(&self, *args, **kw) -> PyResult<PyObject> { def clearcaches(&self, *args, **kw) -> PyResult<PyObject> {
self.nt(py).borrow_mut().take();
self.docket(py).borrow_mut().take();
self.mmap(py).borrow_mut().take();
self.call_cindex(py, "clearcaches", args, kw) self.call_cindex(py, "clearcaches", args, kw)
} }
/// get an index entry /// get an index entry
def get(&self, *args, **kw) -> PyResult<PyObject> { def get(&self, *args, **kw) -> PyResult<PyObject> {
self.call_cindex(py, "get", args, kw) self.call_cindex(py, "get", args, kw)
} }
self.cindex(py).borrow().inner().len(py) self.cindex(py).borrow().inner().len(py)
} }
def __getitem__(&self, key: PyObject) -> PyResult<PyObject> { def __getitem__(&self, key: PyObject) -> PyResult<PyObject> {
// this conversion seems needless, but that's actually because // this conversion seems needless, but that's actually because
// `index_getitem` does not handle conversion from PyLong, // `index_getitem` does not handle conversion from PyLong,
// which expressions such as [e for e in index] internally use. // which expressions such as [e for e in index] internally use.
// Note that we don't seem to have a direct way to call // Note that we don't seem to have a direct way to call
// PySequence_GetItem (does the job), which would be better for // PySequence_GetItem (does the job), which would possibly be better
// for performance // for performance
let key = match key.extract::<Revision>(py) { let key = match key.extract::<Revision>(py) {
Ok(rev) => rev.to_py_object(py).into_object(), Ok(rev) => rev.to_py_object(py).into_object(),
Err(_) => key, Err(_) => key,
}; };
self.cindex(py).borrow().inner().get_item(py, key) self.cindex(py).borrow().inner().get_item(py, key)
} }