This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8183

nodemap: test that an outdated nodemap can catch up
ClosedPublic

Authored by marmoute on Feb 28 2020, 1:54 PM.

Download Raw Diff

Details

Reviewers

None

Group Reviewers

hg-reviewers

Commits

rHG1376cb1c8e34: nodemap: test that an outdated nodemap can catch up

Summary

If the persistent nodemap does not contains all revision that the index
contains, this is should be detected and dealt with. We add a test for this
case.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Feb 28 2020, 1:54 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptFeb 28 2020, 1:54 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

marmoute added a child revision: D8184: nodemap: track the tip_node for validation.Feb 28 2020, 1:54 PM

marmoute added a commit: rHG1376cb1c8e34: nodemap: test that an outdated nodemap can catch up.Mar 10 2020, 4:48 PM

This revision was not accepted when it landed; it landed in state Needs Review.

Closed by commit rHG1376cb1c8e34: nodemap: test that an outdated nodemap can catch up (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

This got cherry picked before the other patches that implement more of the nodemap in rust. As a result test-persistent-nodemap.t breaks.

rebase above latest default up to landed-D8182

Revision Contents
Changeset List

			Path	Packages
M			tests/test-persistent-nodemap.t (39 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	20386		Feb 28 2020, 1:54 PM	★	★
Diff 2	20674	rHG1376cb1c8e34aa3ce0422892bc342365de29f52d	Feb 27 2020, 11:08 AM	★	★
Diff 3	20680		Mar 10 2020, 9:35 PM	★	★

Status	Author	Revision
Closed	marmoute	D8193 nodemap: automatically "vacuum" the persistent nodemap when too sparse
Closed	marmoute	D8192 nodemap: display percentage of unused in `hg debugnodemap`
Closed	marmoute	D8191 nodemap: make sure on disk change get rolled back with the transaction
Closed	marmoute	D8190 nodemap: test that concurrent process don't see the pending transaction
Closed	marmoute	D8316 testlib: adjust wait-on-file timeout according to the global test timeout
Closed	marmoute	D8189 testlib: add a small scrip to help process to synchronise using file
Closed	marmoute	D8188 nodemap: make sure the nodemap docket is updated after the changelog
Closed	marmoute	D8187 nodemap: make sure hooks have access to an up-to-date version
Closed	marmoute	D8186 nodemap: deal with the "debugupdatecache" case using a "fake" transaction
Closed	marmoute	D8185 changelog: change the implementation of `_divertopenener`
Closed	marmoute	D8184 nodemap: track the tip_node for validation
Closed	marmoute	D8183 nodemap: test that an outdated nodemap can catch up
Closed	Alphare	D8162 hghave: add a `rust` keyword to detect the use of compiled rust code
Closed	marmoute	D8180 nodemap: check that a simple lookup works fine
Closed	marmoute	D8182 nodemap: document the docket attributes
Closed	marmoute	D8181 nodemap: add a todo list for getting out of experimental
Closed	Alphare	D8164 rust-nodemap: automatically use the rust index for persistent nodemap
Closed	Alphare	D8163 nodemap: use data from the index in debugnodemap --dump-new
Closed	Alphare	D8161 rust-nodemap: also clear Rust data in `clearcaches`
Closed	Alphare	D8160 rust-nodemap: add binding to `nodemap_update_data`
Closed	Alphare	D8159 rust-nodemap: add binding for `nodemap_data_incremental`
Closed	Alphare	D8158 rust-nodemap: add binding for `nodemap_data_all`
Closed	Alphare	D8157 rust-nodemap: use proper Index API instead of using the C API
Closed	Alphare	D8156 rust-nodemap: add utils for propagating errors
Closed	Alphare	D8155 rust-nodemap: add utils to create `Node`s from Python objects
Closed	Alphare	D8154 rust-index: add `append` method to cindex/Index
Closed	Alphare	D8153 rust-index: moved constructor in separate impl block
Closed	Alphare	D8152 revlog: using two new functions in C capsule from Rust code
Closed	marmoute	D8174 nodemap: refresh the persistent data on nodemap creation
Closed	marmoute	D8173 nodemap: warm the persistent nodemap on disk with debugupdatecache

Diff 20674

tests/test-persistent-nodemap.t

	data-unused: 0			data-unused: 0
	#else			#else
	$ hg debugnodemap --metadata			$ hg debugnodemap --metadata
	uid: ???????????????? (glob)			uid: ???????????????? (glob)
	tip-rev: 5002			tip-rev: 5002
	data-length: 122944			data-length: 122944
	data-unused: 0			data-unused: 0
	#endif			#endif

				Check out of sync nodemap
				=========================

				First copy old data on the side.

				$ mkdir ../tmp-copies
				$ cp .hg/store/00changelog-????????????????.nd .hg/store/00changelog.n ../tmp-copies

				Nodemap lagging behind
				----------------------

				make a new commit

				$ echo bar2 > bar
				$ hg ci -m 'bar2'
				$ NODE=`hg log -r tip -T '{node}\n'`
				$ hg log -r "$NODE" -T '{rev}\n'
				5003

				If the nodemap is lagging behind, it can catch up fine

				$ hg debugnodemap --metadata
				uid: ???????????????? (glob)
				tip-rev: 5003
				data-length: 123200 (pure !)
				data-length: 123200 (rust !)
				data-length: 122944 (no-rust no-pure !)
				data-unused: 256 (pure !)
				data-unused: 256 (rust !)
				data-unused: 0 (no-rust no-pure !)
				$ cp -f ../tmp-copies/* .hg/store/
				$ hg debugnodemap --metadata
				uid: ???????????????? (glob)
				tip-rev: 5002
				data-length: 122944
				data-unused: 0
				$ hg log -r "$NODE" -T '{rev}\n'
				5003