This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8185

changelog: change the implementation of `_divertopenener`
ClosedPublic

Authored by marmoute on Feb 28 2020, 1:54 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG897f0ce4b484: changelog: change the implementation of `_divertopener`
Summary

During a transaction, new data to the changelog index are "diverted". The
previous implementat ways pretty basic, we need something better to be able to
use the changelog vfs fully during transaction. (eg: accessing the vfs options).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Feb 28 2020, 1:54 PM
marmoute added a commit: rHG897f0ce4b484: changelog: change the implementation of `_divertopener`.Mar 10 2020, 4:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG897f0ce4b484: changelog: change the implementation of `_divertopener` (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.
marmoute updated this revision to Diff 20682.Mar 10 2020, 9:35 PM

rebase above latest default up to landed-D8182

Revision Contents
Changeset List

PathPackages
Mmercurial/changelog.py (17 lines)

Diff 20675

mercurial/changelog.py

def __enter__(self): def __enter__(self):
self.fp.__enter__() self.fp.__enter__()
return self return self
def __exit__(self, *args): def __exit__(self, *args):
return self.fp.__exit__(*args) return self.fp.__exit__(*args)
def _divertopener(opener, target): class _divertopener(object):
"""build an opener that writes in 'target.a' instead of 'target'""" def __init__(self, opener, target):
self._opener = opener
self._target = target
def __call__(self, name, mode=b'r', checkambig=False, **kwargs):
if name != self._target:
return self._opener(name, mode, **kwargs)
return self._opener(name + b".a", mode, **kwargs)
def _divert(name, mode=b'r', checkambig=False, **kwargs): def __getattr__(self, attr):
if name != target: return getattr(self._opener, attr)
return opener(name, mode, **kwargs)
return opener(name + b".a", mode, **kwargs)
return _divert
def _delayopener(opener, target, buf): def _delayopener(opener, target, buf):
"""build an opener that stores chunks in 'buf' instead of 'target'""" """build an opener that stores chunks in 'buf' instead of 'target'"""
def _delay(name, mode=b'r', checkambig=False, **kwargs): def _delay(name, mode=b'r', checkambig=False, **kwargs):
if name != target: if name != target:
return opener(name, mode, **kwargs) return opener(name, mode, **kwargs)