This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8186

nodemap: deal with the "debugupdatecache" case using a "fake" transaction
ClosedPublic

Authored by marmoute on Feb 28 2020, 1:54 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG3265c92f7d13: nodemap: deal with the "debugupdatecache" case using a "fake" transaction
Summary

We are going to need more and more methods of the transaction. So lets change
approach. The hg debugupdatecache case do not need a transaction, because has
the repositories locked, but is not adding any "store" data to it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Feb 28 2020, 1:54 PM
marmoute added a commit: rHG3265c92f7d13: nodemap: deal with the "debugupdatecache" case using a "fake" transaction.Mar 10 2020, 4:48 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG3265c92f7d13: nodemap: deal with the "debugupdatecache" case using a "fake" transaction (authored by marmoute). · Explain Why
This revision was automatically updated to reflect the committed changes.
marmoute updated this revision to Diff 20683.Mar 10 2020, 9:35 PM

rebase above latest default up to landed-D8182

Revision Contents
Changeset List

PathPackages
Mmercurial/revlogutils/nodemap.py (27 lines)

Diff 20676

mercurial/revlogutils/nodemap.py

""" """
if revlog._inline: if revlog._inline:
return # inlined revlog are too small for this to be relevant return # inlined revlog are too small for this to be relevant
if revlog.nodemap_file is None: if revlog.nodemap_file is None:
return # we do not use persistent_nodemap on this revlog return # we do not use persistent_nodemap on this revlog
callback_id = b"revlog-persistent-nodemap-%s" % revlog.nodemap_file callback_id = b"revlog-persistent-nodemap-%s" % revlog.nodemap_file
if tr.hasfinalize(callback_id): if tr.hasfinalize(callback_id):
return # no need to register again return # no need to register again
tr.addfinalize( tr.addfinalize(callback_id, lambda tr: _persist_nodemap(tr, revlog))
callback_id, lambda tr: _persist_nodemap(tr.addpostclose, revlog)
)
class _NoTransaction(object):
"""transaction like object to update the nodemap outside a transaction
"""
def __init__(self):
self._postclose = {}
def addpostclose(self, callback_id, callback_func):
self._postclose[callback_id] = callback_func
def update_persistent_nodemap(revlog): def update_persistent_nodemap(revlog):
"""update the persistent nodemap right now """update the persistent nodemap right now
To be used for updating the nodemap on disk outside of a normal transaction To be used for updating the nodemap on disk outside of a normal transaction
setup (eg, `debugupdatecache`). setup (eg, `debugupdatecache`).
""" """
cleanups = [] notr = _NoTransaction()
_persist_nodemap((lambda x, y: cleanups.append(y)), revlog) _persist_nodemap(notr, revlog)
for c in cleanups: for k in sorted(notr._postclose):
c(None) notr._postclose[k](None)
def _persist_nodemap(cleaner, revlog): def _persist_nodemap(tr, revlog):
"""Write nodemap data on disk for a given revlog """Write nodemap data on disk for a given revlog
""" """
if getattr(revlog, 'filteredrevs', ()): if getattr(revlog, 'filteredrevs', ()):
raise error.ProgrammingError( raise error.ProgrammingError(
"cannot persist nodemap of a filtered changelog" "cannot persist nodemap of a filtered changelog"
) )
if revlog.nodemap_file is None: if revlog.nodemap_file is None:
msg = "calling persist nodemap on a revlog without the feature enableb" msg = "calling persist nodemap on a revlog without the feature enableb"
if olds: if olds:
realvfs = getattr(revlog, '_realopener', revlog.opener) realvfs = getattr(revlog, '_realopener', revlog.opener)
def cleanup(tr): def cleanup(tr):
for oldfile in olds: for oldfile in olds:
realvfs.tryunlink(oldfile) realvfs.tryunlink(oldfile)
callback_id = b"revlog-cleanup-nodemap-%s" % revlog.nodemap_file callback_id = b"revlog-cleanup-nodemap-%s" % revlog.nodemap_file
cleaner(callback_id, cleanup) tr.addpostclose(callback_id, cleanup)
### Nodemap docket file ### Nodemap docket file
# #
# The nodemap data are stored on disk using 2 files: # The nodemap data are stored on disk using 2 files:
# #
# * a raw data files containing a persistent nodemap # * a raw data files containing a persistent nodemap
# (see `Nodemap Trie` section) # (see `Nodemap Trie` section)