This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8291

rebase: remove unused defaults argument values from _definedestmap()
ClosedPublic

Authored by martinvonz on Mar 13 2020, 8:23 PM.

Details

Reviewers
mharbison72
pulkit
marmoute
Group Reviewers
hg-reviewers
Commits
rHGdc25de8117e4: rebase: remove unused defaults argument values from _definedestmap()
Summary

The caller always provides values for these arguments.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mhgext/rebase.py (11 lines)

Diff 20782

hgext/rebase.py

if singletr and not inmemory: if singletr and not inmemory:
dsguard = dirstateguard.dirstateguard(repo, b'rebase') dsguard = dirstateguard.dirstateguard(repo, b'rebase')
with util.acceptintervention(dsguard): with util.acceptintervention(dsguard):
rbsrt._performrebase(tr) rbsrt._performrebase(tr)
if not leaveunfinished: if not leaveunfinished:
rbsrt._finishrebase() rbsrt._finishrebase()
def _definedestmap( def _definedestmap(ui, repo, inmemory, destf, srcf, basef, revf, destspace):
ui,
repo,
inmemory,
destf=None,
srcf=None,
basef=None,
revf=None,
destspace=None,
):
"""use revisions argument to define destmap {srcrev: destrev}""" """use revisions argument to define destmap {srcrev: destrev}"""
if revf is None: if revf is None:
revf = [] revf = []
# destspace is here to work around issues with `hg pull --rebase` see # destspace is here to work around issues with `hg pull --rebase` see
# issue5214 for details # issue5214 for details
cmdutil.checkunfinished(repo) cmdutil.checkunfinished(repo)