This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8301

phabricator: remove duplicated byteskwargs conversion
ClosedPublic

Authored by durin42 on Mar 18 2020, 3:12 PM.

Details

Reviewers
mharbison72
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3aab524a8480: phabricator: remove duplicated byteskwargs conversion
Summary

Fixes things on Python 3.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

durin42 created this revision.Mar 18 2020, 3:12 PM
mharbison72 accepted this revision.Mar 18 2020, 4:26 PM
mharbison72 added a subscriber: mharbison72.

Thanks, I just hit this myself.

It also looks like the create alpha for phabricator test € test is broken. Can we get the pytest-vcr package installed on the builders?

pulkit accepted this revision.Mar 19 2020, 4:03 AM
This revision is now accepted and ready to land.Mar 19 2020, 4:03 AM
durin42 added a commit: rHG3aab524a8480: phabricator: remove duplicated byteskwargs conversion.Mar 19 2020, 4:45 AM
Closed by commit rHG3aab524a8480: phabricator: remove duplicated byteskwargs conversion (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/phabricator.py (1 line)

Diff 20825

hgext/phabricator.py

) )
if not node: if not node:
raise error.Abort(_(b'D%s: no diffs found') % drev) raise error.Abort(_(b'D%s: no diffs found') % drev)
ui.note(msg + b'\n') ui.note(msg + b'\n')
parents = [repo[node]] parents = [repo[node]]
opts = pycompat.byteskwargs(opts)
if opts.get(b'stack'): if opts.get(b'stack'):
spec = b':(%s)' % spec spec = b':(%s)' % spec
drevs = querydrev(repo.ui, spec) drevs = querydrev(repo.ui, spec)
readpatch(repo.ui, drevs, _write) readpatch(repo.ui, drevs, _write)
@vcrcommand( @vcrcommand(