Details
Details
Diff Detail
Diff Detail
- Repository
- rHG Mercurial
- Branch
- default
- Lint
No Linters Available - Unit
No Unit Test Coverage
This is an archive of the discontinued Mercurial Phabricator instance.
Differential D8375
manifest: leave a TODO where we may have more work for sha1 portabilityClosedPublic
manifest: leave a TODO where we may have more work for sha1 portability
ClosedPublic
Authored by durin42 on Apr 2 2020, 4:32 PM.
Revision Contents
Revision Contents
Diff 20978
Diff 20978
mercurial/manifest.py
| if self._read or self._opener is None: | if self._read or self._opener is None: | ||||
| return | return | ||||
| try: | try: | ||||
| with self._opener(self._file) as fp: | with self._opener(self._file) as fp: | ||||
| set = super(manifestfulltextcache, self).__setitem__ | set = super(manifestfulltextcache, self).__setitem__ | ||||
| # ignore trailing data, this is a cache, corruption is skipped | # ignore trailing data, this is a cache, corruption is skipped | ||||
| while True: | while True: | ||||
| # TODO do we need to do work here for sha1 portability? | |||||
| node = fp.read(20) | node = fp.read(20) | ||||
| if len(node) < 20: | if len(node) < 20: | ||||
| break | break | ||||
| try: | try: | ||||
| size = struct.unpack(b'>L', fp.read(4))[0] | size = struct.unpack(b'>L', fp.read(4))[0] | ||||
| except struct.error: | except struct.error: | ||||
| break | break | ||||
| value = bytearray(fp.read(size)) | value = bytearray(fp.read(size)) | ||||