This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	20978		Apr 2 2020, 4:32 PM	★	★
Diff 2	21055		Apr 14 2020, 11:29 AM	★	★
Diff 3	21087	rHGf0d88d20654ba1bc6a3c42c6dd06cc366142879d	Apr 2 2020, 4:02 PM	★	★

Status	Author	Revision
Abandoned	durin42	D8424 manifest: fix missing `el` on an `elif` spotted by yuya
Closed	durin42	D8375 manifest: leave a TODO where we may have more work for sha1 portability
Closed	durin42	D8374 fuzz: tell manifest fuzzer about longer node hashes
Closed	durin42	D8373 manifest: add test for long hashes
Closed	durin42	D8372 manifest: remove a final 40-byte assumption from pure-python parser
Closed	durin42	D8371 manifest: fix yet another 20-byte-hash assumption
Closed	durin42	D8370 manifest: fix another pure-parsing 20-byte assumption
Closed	durin42	D8369 manifest: teach treemanifest about long hashes
Closed	durin42	D8368 manifest: start removing 40-byte hash restrictions from C code
Closed	durin42	D8367 manifest: remove a 20-byte-hash assumption from pure manifest parsing

Diff 21087

	if self._read or self._opener is None:			if self._read or self._opener is None:
	return			return

	try:			try:
	with self._opener(self._file) as fp:			with self._opener(self._file) as fp:
	set = super(manifestfulltextcache, self).__setitem__			set = super(manifestfulltextcache, self).__setitem__
	# ignore trailing data, this is a cache, corruption is skipped			# ignore trailing data, this is a cache, corruption is skipped
	while True:			while True:
				# TODO do we need to do work here for sha1 portability?
	node = fp.read(20)			node = fp.read(20)
	if len(node) < 20:			if len(node) < 20:
	break			break
	try:			try:
	size = struct.unpack(b'>L', fp.read(4))[0]			size = struct.unpack(b'>L', fp.read(4))[0]
	except struct.error:			except struct.error:
	break			break
	value = bytearray(fp.read(size))			value = bytearray(fp.read(size))