( )⚙ D8437 phabricator: prevent posting obsolete commits

This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: prevent posting obsolete commits
ClosedPublic

Authored by mharbison72 on Apr 15 2020, 7:57 PM.

Details

Summary

I don't see why this would be useful in the first place. But I had a coworker
submit a single commit that was not a branch head, and the result was to orphan
its child and keep the original commit visible. He then did up arrow + Enter,
and it happily created a new review (since the URL isn't amended into the
original commit specified on the command line) and a new successor, resulting in
a local divergence. I'd like to fix the issue with creating orphans, but this
is simple enough to prevent on its own.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Apr 15 2020, 7:57 PM
Alphare accepted this revision.Apr 16 2020, 9:57 AM
Alphare added a subscriber: Alphare.

I think that these kinds of fail-safes are very useful. I might have been bit by this once.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.