This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: restack any new orphans created by phabsend (issue6045)
ClosedPublic

Authored by mharbison72 on Apr 15 2020, 7:57 PM.

Details

Summary

Previously, posting a new review for a non head commit would orphan the head.
The general case is any descendant of the selected revisions got orphaned if
this was the first time the selected revisions were submitted. It doesn't
happen when resubmitting. I've already had coworkers hit this a few times and
get confused. Since posting a review isn't generally thought of as an editing
operation, it would probably be easier for new users if we just restacked.

This avoids restacking existing orphans around the submission because that may
involve merge conflict resolution. Users who already have orphans should know
how to stabilize them anyway.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Apr 15 2020, 7:57 PM
Alphare accepted this revision.Apr 16 2020, 10:01 AM
Alphare added a subscriber: Alphare.

A feature I've always wanted but never bothered to speak up about it, thanks.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.