This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	martinvonz	D8496 copy: give better error message when no source paths found with --at-rev
Closed	martinvonz	D8495 tests: show poor error message for `hg cp -A --at-rev . non-existent dst`
Closed	martinvonz	D8494 copy: to find copy source, walk parent of revision we're marking copies in
Closed	martinvonz	D8493 tests: show that `hg cp -A --at-rev .` doesn't work for renames

Diff 21314

	copylist = []			copylist = []
	for pat in pats:			for pat in pats:
	srcs = walkpat(pat)			srcs = walkpat(pat)
	if not srcs:			if not srcs:
	continue			continue
	for abs, rel, exact in srcs:			for abs, rel, exact in srcs:
	copylist.append(abs)			copylist.append(abs)

				if not copylist:
				raise error.Abort(_(b'no files to copy'))
	# TODO: Add support for `hg cp --at-rev . foo bar dir` and			# TODO: Add support for `hg cp --at-rev . foo bar dir` and
	# `hg cp --at-rev . dir1 dir2`, preferably unifying the code with the			# `hg cp --at-rev . dir1 dir2`, preferably unifying the code with the
	# existing functions below.			# existing functions below.
	if len(copylist) != 1:			if len(copylist) != 1:
	raise error.Abort(_(b'--at-rev requires a single source'))			raise error.Abort(_(b'--at-rev requires a single source'))

	new_ctx = context.overlayworkingctx(repo)			new_ctx = context.overlayworkingctx(repo)
	new_ctx.setbase(ctx.p1())			new_ctx.setbase(ctx.p1())

	A d1/c			A d1/c
	d1/b			d1/b
	A d1/d			A d1/d
	# Errors out without --after for now			# Errors out without --after for now
	$ hg cp --at-rev . d1/b d1/d			$ hg cp --at-rev . d1/b d1/d
	abort: --at-rev requires --after			abort: --at-rev requires --after
	[255]			[255]
	# Errors out with non-existent source			# Errors out with non-existent source
	BROKEN: this should have a better error message
	$ hg cp -A --at-rev . d1/non-existent d1/d			$ hg cp -A --at-rev . d1/non-existent d1/d
	d1/non-existent: no such file in rev 55d1fd85ef0a			d1/non-existent: no such file in rev 55d1fd85ef0a
	abort: --at-rev requires a single source			abort: no files to copy
	[255]			[255]
	# Errors out with non-existent destination			# Errors out with non-existent destination
	$ hg cp -A --at-rev . d1/b d1/non-existent			$ hg cp -A --at-rev . d1/b d1/non-existent
	abort: d1/non-existent: copy destination does not exist in 8a9d70fa20c9			abort: d1/non-existent: copy destination does not exist in 8a9d70fa20c9
	[255]			[255]
	# Successful invocation			# Successful invocation
	$ hg cp -A --at-rev . d1/b d1/d			$ hg cp -A --at-rev . d1/b d1/d
	saved backup bundle to $TESTTMP/.hg/strip-backup/8a9d70fa20c9-973ae357-copy.hg			saved backup bundle to $TESTTMP/.hg/strip-backup/8a9d70fa20c9-973ae357-copy.hg