This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8580

grep: add test coverage of behavior on symlinks
ClosedPublic

Authored by valentin.gatienbaron on May 25 2020, 7:42 PM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG3db660b8eba6: grep: add test coverage of behavior on symlinks

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute requested changes to this revision.May 26 2020, 9:53 AM
marmoute added a subscriber: marmoute.

It would be nice to have some comments in the test to explain what is exactly test here, it is a bit obscure from just reading the test.

This revision now requires changes to proceed.May 26 2020, 9:53 AM
valentin.gatienbaron added a commit: rHG3db660b8eba6: grep: add test coverage of behavior on symlinks.May 28 2020, 12:23 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG3db660b8eba6: grep: add test coverage of behavior on symlinks (authored by valentin.gatienbaron). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-grep.t (10 lines)

Diff 21493

tests/test-grep.t

$ echo 'untracked' > untracked $ echo 'untracked' > untracked
$ hg rm old $ hg rm old
$ hg grep '' $ hg grep ''
added:added added:added
new:something else new:something else
new:modified new:modified
um:unmod um:unmod
which can be overridden by -rREV #if symlink
Grepping a symlink greps its destination
$ rm -f added; ln -s symlink-added added
$ hg grep '' | grep added
added:symlink-added
#endif
But we can search files from some other revision with -rREV
$ hg grep -r. mod $ hg grep -r. mod
um:1:unmod um:1:unmod
$ hg grep --diff mod $ hg grep --diff mod
um:0:+:unmod um:0:+:unmod
$ cd .. $ cd ..