Details
- Reviewers
Alphare - Group Reviewers
hg-reviewers - Commits
- rHG5965efb609b6: hg-core: add FindRoot operation to find repository root path
Diff Detail
- Repository
- rHG Mercurial
- Branch
- default
- Lint
No Linters Available - Unit
No Unit Test Coverage
Event Timeline
Pathc looks overall good to me. I have a question regarding the test about some potential tempfile leackage that I woudl like clarified.
rust/hg-core/src/operations/find_root.rs | ||
---|---|---|
22 | (small nits: s/current/current/) | |
70 | small nits: s/anscestors/ancestors/ | |
91 | Do we have to do anything to make sure the temporary directory is deleted at the end of the run ? or are we leaking them ? |
rust/hg-core/src/operations/find_root.rs | ||
---|---|---|
11 | nit: s/exists/exist | |
91 | https://docs.rs/tempfile/3.1.0/tempfile/struct.TempDir.html#resource-leaking This is what tempfile does, whether that's acceptable is arguable. |
nit: s/exists/exist