This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8627

rhg: add rhg tests to the Rust tests
ClosedPublic

Authored by marmoute on Jun 13 2020, 5:07 AM.

Download Raw Diff

Details

Reviewers

pulkit

Group Reviewers

hg-reviewers

Commits

rHGba7eda4fcf8e: zeroconf: fix non existant formatting in the vendored zeroconf module

Summary

On Tue Mar 1st 2016 at 09:33:39 timeless decided to wrap long line in
hgext/zeroconf/Zeroconf.py. Doing so, he fat fingered a "%w" instead of a "%s"
in a string. %w does not exists, 4 year later, pyflakes (rightfully) complains
about it. So I am fixing it.

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

marmoute created this revision.Jun 13 2020, 5:07 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJun 13 2020, 5:07 AM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

marmoute added a child revision: D8628: tests: skip pyflakes for mercurial/thirdparty/.Jun 13 2020, 5:07 AM

pulkit accepted this revision.Jun 15 2020, 4:23 AM

This revision is now accepted and ready to land.Jun 15 2020, 4:23 AM

marmoute added a commit: rHGba7eda4fcf8e: zeroconf: fix non existant formatting in the vendored zeroconf module.Jun 15 2020, 5:27 AM

Closed by commit rHGba7eda4fcf8e: zeroconf: fix non existant formatting in the vendored zeroconf module (authored by marmoute). · Explain Why

This revision was automatically updated to reflect the committed changes.

acezar added a parent revision: D8613: rhg: add a limited `rhg root` subcommand.Jun 17 2020, 4:25 AM

acezar retitled this revision from zeroconf: fix non existant formatting in the vendored zeroconf module to rhg: add rhg tests to the Rust tests.

acezar updated this revision to Diff 21658.

Revision Contents
Changeset List

			Path	Packages
M			Makefile (1 line)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	21626		Jun 13 2020, 5:07 AM	★	★
Diff 2	21630	rHGba7eda4fcf8e64478812893ff3c83da23959f805	Jun 13 2020, 5:06 AM	★	★
Diff 3	21658		Jun 17 2020, 4:25 AM	★	★

Commit	Parents	Author	Summary	Date
7bdcb5d7607a	0c9e85b53b1a	Antoine Cezar		Jun 17 2020, 4:15 AM

Status	Author	Revision
Closed	marmoute	D8630 tests: adjust to the new format in pyflakes output
Closed	marmoute	D8629 tests: consistently use pyflakes as a Python module
Closed	marmoute	D8628 tests: skip pyflakes for mercurial/thirdparty/
Closed	marmoute	D8627 rhg: add rhg tests to the Rust tests
Abandoned	acezar	D8614 rhg: add rhg tests to the Rust tests
Closed	acezar	D8613 rhg: add a limited `rhg root` subcommand
Closed	acezar	D8612 rhg: add RootCommand using hg-core FindRoot operation to prepare `hg root`
Closed	acezar	D8611 rhg: add Command trait for subcommands implemented by rhg
Closed	acezar	D8610 rhg: add rhg crate
Closed	acezar	D8609 hg-core: add FindRoot operation to find repository root path
Closed	acezar	D8608 hg-core: add Operation interface for high-level hg operations

Diff 21658

Makefile

	cd tests && $(HGPYTHONS)/$*/bin/python run-tests.py $(TESTFLAGS)			cd tests && $(HGPYTHONS)/$*/bin/python run-tests.py $(TESTFLAGS)

	rust-tests: py_feature = $(shell $(PYTHON) -c \			rust-tests: py_feature = $(shell $(PYTHON) -c \
	'import sys; print(["python27-bin", "python3-bin"][sys.version_info[0] >= 3])')			'import sys; print(["python27-bin", "python3-bin"][sys.version_info[0] >= 3])')
	rust-tests:			rust-tests:
	cd $(HGROOT)/rust/hg-cpython \			cd $(HGROOT)/rust/hg-cpython \
	&& $(CARGO) test --quiet --all \			&& $(CARGO) test --quiet --all \
	--no-default-features --features "$(py_feature)"			--no-default-features --features "$(py_feature)"
				cd $(HGROOT)/rust/rhg && $(CARGO) test --quiet

	check-code:			check-code:
	hg manifest \| xargs python contrib/check-code.py			hg manifest \| xargs python contrib/check-code.py

	format-c:			format-c:
	clang-format --style file -i \			clang-format --style file -i \
	`hg files 'set:(.c or .cc or **.h) and not "listfile:contrib/clang-format-ignorelist"'`			`hg files 'set:(.c or .cc or **.h) and not "listfile:contrib/clang-format-ignorelist"'`