Page MenuHomePhabricator

tests: skip pyflakes for mercurial/thirdparty/
ClosedPublic

Authored by marmoute on Jun 13 2020, 5:07 AM.

Details

Summary

The current version of pyflakes (2.2.0) correctly detects one issue:

mercurial/thirdparty/selectors2.py:335:40 '...'.format(...) has unused arguments at position(s): 1

But we're not interested in fixing lint errors in third-party code, so we need
to exclude at least selectors2.py. And in the discussion for this patch it was
decided to just skip the entire thirdparty directory.

This is a graft of a similar fix that ended up on default.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Jun 13 2020, 5:07 AM
pulkit accepted this revision.Jun 15 2020, 4:24 AM
This revision is now accepted and ready to land.Jun 15 2020, 4:24 AM
This revision was automatically updated to reflect the committed changes.