This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8628

tests: skip pyflakes for mercurial/thirdparty/
ClosedPublic

Authored by marmoute on Jun 13 2020, 5:07 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG1ca0d5cae9bc: tests: skip pyflakes for mercurial/thirdparty/
Summary

The current version of pyflakes (2.2.0) correctly detects one issue:

mercurial/thirdparty/selectors2.py:335:40 '...'.format(...) has unused arguments at position(s): 1

But we're not interested in fixing lint errors in third-party code, so we need
to exclude at least selectors2.py. And in the discussion for this patch it was
decided to just skip the entire thirdparty directory.

This is a graft of a similar fix that ended up on default.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Jun 13 2020, 5:07 AM
pulkit accepted this revision.Jun 15 2020, 4:24 AM
This revision is now accepted and ready to land.Jun 15 2020, 4:24 AM
av6 added a commit: rHG1ca0d5cae9bc: tests: skip pyflakes for mercurial/thirdparty/.Jun 15 2020, 5:27 AM
Closed by commit rHG1ca0d5cae9bc: tests: skip pyflakes for mercurial/thirdparty/ (authored by av6). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-check-pyflakes.t (4 lines)

Diff 21627

tests/test-check-pyflakes.t

$ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py" $ pyflakes test.py 2>/dev/null | "$TESTDIR/filterpyflakes.py"
test.py:1: undefined name 'undefinedname' test.py:1: undefined name 'undefinedname'
$ cd "`dirname "$TESTDIR"`" $ cd "`dirname "$TESTDIR"`"
$ testrepohg locate 'set:**.py or grep("^#!.*python")' \ $ testrepohg locate 'set:**.py or grep("^#!.*python")' \
> -X hgext/fsmonitor/pywatchman \ > -X hgext/fsmonitor/pywatchman \
> -X mercurial/pycompat.py -X contrib/python-zstandard \ > -X mercurial/pycompat.py -X contrib/python-zstandard \
> -X mercurial/thirdparty/cbor \ > -X mercurial/thirdparty \
> -X mercurial/thirdparty/concurrent \
> -X mercurial/thirdparty/zope \
> 2>/dev/null \ > 2>/dev/null \
> | xargs $PYTHON -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py" > | xargs $PYTHON -m pyflakes 2>/dev/null | "$TESTDIR/filterpyflakes.py"
contrib/perf.py:*: undefined name 'xrange' (glob) (?) contrib/perf.py:*: undefined name 'xrange' (glob) (?)
mercurial/hgweb/server.py:*: undefined name 'reload' (glob) (?) mercurial/hgweb/server.py:*: undefined name 'reload' (glob) (?)
mercurial/util.py:*: undefined name 'file' (glob) (?) mercurial/util.py:*: undefined name 'file' (glob) (?)
mercurial/encoding.py:*: undefined name 'localstr' (glob) (?) mercurial/encoding.py:*: undefined name 'localstr' (glob) (?)