This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8644

util: provide a helper function to estimate RAM size
ClosedPublic

Authored by joerg.sonnenberger on Jun 21 2020, 6:40 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG02b17231f6c3: util: provide a helper function to estimate RAM size
rHGcfe0f4915793: util: provide a helper function to estimate RAM size
Summary

For POSIX systems, it uses sysconf. For Windows, it uses the win32 API
directly.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

joerg.sonnenberger added a comment.Jun 21 2020, 6:41 PM

This currently triggers a warning about using ui in util, so consider this a RFC for dealing with that.

pulkit added a subscriber: pulkit.Jul 7 2020, 2:08 PM
pulkit added inline comments.
mercurial/ui.py
2108 ↗(On Diff #21735)

nit: can fail by returning None -> if we fails to calculate the memory, None is returned.

mercurial/util.py
3636

Can we move this try-expect in a if not windows: and also some comments on errors caught as why they are caught?

pulkit accepted this revision.Jul 10 2020, 6:02 AM
This revision is now accepted and ready to land.Jul 10 2020, 6:02 AM

Revision Contents
Changeset List

PathPackages
Mmercurial/configitems.py (4 lines)
Mmercurial/util.py (44 lines)

Diff 21672

mercurial/configitems.py

) )
coreconfigitem( coreconfigitem(
b'ui', b'archivemeta', default=True, b'ui', b'archivemeta', default=True,
) )
coreconfigitem( coreconfigitem(
b'ui', b'askusername', default=False, b'ui', b'askusername', default=False,
) )
coreconfigitem( coreconfigitem(
b'ui', b'available-memory', default=None,
)
coreconfigitem(
b'ui', b'clonebundlefallback', default=False, b'ui', b'clonebundlefallback', default=False,
) )
coreconfigitem( coreconfigitem(
b'ui', b'clonebundleprefers', default=list, b'ui', b'clonebundleprefers', default=list,
) )
coreconfigitem( coreconfigitem(
b'ui', b'clonebundles', default=True, b'ui', b'clonebundles', default=True,
) )

mercurial/util.py

result = 0 result = 0
shift = 0 shift = 0
while True: while True:
byte = ord(readexactly(fh, 1)) byte = ord(readexactly(fh, 1))
result |= (byte & 0x7F) << shift result |= (byte & 0x7F) << shift
if not (byte & 0x80): if not (byte & 0x80):
return result return result
shift += 7 shift += 7
def estimatememory(ui):
"""Provide an estimate for the available system memory in Bytes.
If no estimate can be provided on the platform, returns None.
"""
value = ui.config(b'ui', b'available-memory')
pulkitUnsubmitted
Not Done

Can we move this try-expect in a if not windows: and also some comments on errors caught as why they are caught?

pulkit: Can we move this `try`-`expect` in a `if not windows:` and also some comments on errors caught…
if value is not None:
try:
return sizetoint(value)
except error.ParseError:
raise error.ConfigError(
_(b"ui.available-memory value is invalid ('%s')") % value
)
try:
pagesize = os.sysconf(os.sysconf_names['SC_PAGE_SIZE'])
pages = os.sysconf(os.sysconf_names['SC_PHYS_PAGES'])
return pagesize * pages
except OSError:
pass
except KeyError:
pass
if pycompat.sysplatform.startswith(b'win'):
from ctypes import c_long as DWORD, c_ulonglong as DWORDLONG
from ctypes.wintypes import Structure, byref, sizeof, windll
class MEMORYSTATUSEX(Structure):
_fields_ = [
('dwLength', DWORD),
('dwMemoryLoad', DWORD),
('ullTotalPhys', DWORDLONG),
('ullAvailPhys', DWORDLONG),
('ullTotalPageFile', DWORDLONG),
('ullAvailPageFile', DWORDLONG),
('ullTotalVirtual', DWORDLONG),
('ullAvailVirtual', DWORDLONG),
('ullExtendedVirtual', DWORDLONG),
]
x = MEMORYSTATUSEX()
x.dwLength = sizeof(x)
windll.kernel32.GlobalMemoryStatusEx(byref(x))
return x.ullAvailPhys