This is an archive of the discontinued Mercurial Phabricator instance.

mercurial/ui.py
2108	nit: `can fail by returning None` -> `if we fails to calculate the memory, None is returned.`
mercurial/util.py
3636	Can we move this `try`-`expect` in a `if not windows:` and also some comments on errors caught as why they are caught?

This revision is now accepted and ready to land.Jul 10 2020, 6:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			mercurial/configitems.py (4 lines)
M			mercurial/ui.py (16 lines)
M			mercurial/util.py (36 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	21672		Jun 21 2020, 6:40 PM	★	★
Diff 2	21735		Jun 30 2020, 5:25 PM	★	★
Diff 3	21788		Jul 7 2020, 3:06 PM	★	★
Diff 4	21824	rHGcfe0f4915793d8fbc5c3c624b5c1b5cd1b28f56a	Jun 9 2020, 5:22 AM	★	★

Commit	Parents	Author	Summary	Date
4977697e050f	cadd5bac71a0	Joerg Sonnenberger		Jun 9 2020, 5:22 AM

	Status	Author	Revision
	Closed	joerg.sonnenberger	D8645 clonebundles: optional memory-requirement attribution
	Closed	joerg.sonnenberger	D8644 util: provide a helper function to estimate RAM size

	)			)
	coreconfigitem(			coreconfigitem(
	b'ui', b'archivemeta', default=True,			b'ui', b'archivemeta', default=True,
	)			)
	coreconfigitem(			coreconfigitem(
	b'ui', b'askusername', default=False,			b'ui', b'askusername', default=False,
	)			)
	coreconfigitem(			coreconfigitem(
				b'ui', b'available-memory', default=None,
				)

				coreconfigitem(
	b'ui', b'clonebundlefallback', default=False,			b'ui', b'clonebundlefallback', default=False,
	)			)
	coreconfigitem(			coreconfigitem(
	b'ui', b'clonebundleprefers', default=list,			b'ui', b'clonebundleprefers', default=list,
	)			)
	coreconfigitem(			coreconfigitem(
	b'ui', b'clonebundles', default=True,			b'ui', b'clonebundles', default=True,
	)			)

	finally:			finally:
	for __, backup in backups.items():			for __, backup in backups.items():
	self.restoreconfig(backup)			self.restoreconfig(backup)
	# just restoring ui.quiet config to the previous value is not enough			# just restoring ui.quiet config to the previous value is not enough
	# as it does not update ui.quiet class member			# as it does not update ui.quiet class member
	if (b'ui', b'quiet') in overrides:			if (b'ui', b'quiet') in overrides:
	self.fixconfig(section=b'ui')			self.fixconfig(section=b'ui')

				def estimatememory(self):
				"""Provide an estimate for the available system memory in Bytes.

				This can be overriden via ui.available-memory and can fail by
				pulkitUnsubmitted Not Done nit: `can fail by returning None` -> `if we fails to calculate the memory, None is returned.` pulkit: nit: `can fail by returning None` -> `if we fails to calculate the memory, None is returned.`
				returning None.
				"""
				value = self.config(b'ui', b'available-memory')
				if value is not None:
				try:
				return util.sizetoint(value)
				except error.ParseError:
				raise error.ConfigError(
				_(b"ui.available-memory value is invalid ('%s')") % value
				)
				return util._estimatememory()


	class paths(dict):			class paths(dict):
	"""Represents a collection of paths and their configs.			"""Represents a collection of paths and their configs.

	Data is initially derived from ui instances and the config files they have			Data is initially derived from ui instances and the config files they have
	loaded.			loaded.
	"""			"""

	result = 0			result = 0
	shift = 0			shift = 0
	while True:			while True:
	byte = ord(readexactly(fh, 1))			byte = ord(readexactly(fh, 1))
	result \|= (byte & 0x7F) << shift			result \|= (byte & 0x7F) << shift
	if not (byte & 0x80):			if not (byte & 0x80):
	return result			return result
	shift += 7			shift += 7


				def _estimatememory():
				"""Provide an estimate for the available system memory in Bytes.

				If no estimate can be provided on the platform, returns None.
				"""
				try:
				pulkitUnsubmitted Not Done Can we move this `try`-`expect` in a `if not windows:` and also some comments on errors caught as why they are caught? pulkit: Can we move this `try`-`expect` in a `if not windows:` and also some comments on errors caught…
				pagesize = os.sysconf(os.sysconf_names['SC_PAGE_SIZE'])
				pages = os.sysconf(os.sysconf_names['SC_PHYS_PAGES'])
				return pagesize * pages
				except OSError:
				pass
				except KeyError:
				pass
				if pycompat.sysplatform.startswith(b'win'):
				from ctypes import c_long as DWORD, c_ulonglong as DWORDLONG
				from ctypes.wintypes import Structure, byref, sizeof, windll

				class MEMORYSTATUSEX(Structure):
				_fields_ = [
				('dwLength', DWORD),
				('dwMemoryLoad', DWORD),
				('ullTotalPhys', DWORDLONG),
				('ullAvailPhys', DWORDLONG),
				('ullTotalPageFile', DWORDLONG),
				('ullAvailPageFile', DWORDLONG),
				('ullTotalVirtual', DWORDLONG),
				('ullAvailVirtual', DWORDLONG),
				('ullExtendedVirtual', DWORDLONG),
				]

				x = MEMORYSTATUSEX()
				x.dwLength = sizeof(x)
				windll.kernel32.GlobalMemoryStatusEx(byref(x))
				return x.ullAvailPhys