Page MenuHomePhabricator

config: add a .hg/nonsharedrc which won't be shared in share-safe mode
Needs ReviewPublic

Authored by pulkit on Jul 1 2020, 6:01 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Summary

Previous patches add a safe mode for sharing repositories which involve sharing
of source requirements and config files.

In certain situations we might need to add a config to source repository which
we does not want to share. For this, we add a .hg/nonsharedrc which won't be
shared.

This also adds a --non-shared flag to hg config command to see the
non-shared config.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Jul 1 2020, 6:01 AM
pulkit updated this revision to Diff 21755.Jul 2 2020, 7:17 AM
marmoute requested changes to this revision.Wed, Jul 15, 2:14 PM
marmoute added a subscriber: marmoute.

Request changes because of my inline question on the conditional.

Extra question: Do we need a "non-shared" option on hg config to edit the new file ?

mercurial/localrepo.py
753

Why this limitation ? Can't a share have this file too ?

This revision now requires changes to proceed.Wed, Jul 15, 2:14 PM

Request changes because of my inline question on the conditional.
Extra question: Do we need a "non-shared" option on hg config to edit the new file ?

Seems like yes. We will need one. Adding a patch for that too.

mercurial/localrepo.py
753

It can have. Fixing in next version.

pulkit edited the summary of this revision. (Show Details)Mon, Jul 20, 8:16 AM
pulkit updated this revision to Diff 21980.
marmoute accepted this revision.Mon, Jul 20, 1:23 PM
pulkit updated this revision to Diff 22003.Tue, Jul 21, 9:43 AM
pulkit updated this revision to Diff 22072.Thu, Jul 23, 10:54 AM
pulkit updated this revision to Diff 22224.Mon, Aug 3, 9:14 AM