This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8857

packaging: delete unnecessary updating of `dirs` list
ClosedPublic

Authored by martinvonz on Jul 31 2020, 7:59 PM.

Download Raw Diff

Details

Reviewers

indygreg

Group Reviewers

hg-reviewers

Commits

rHGc8655782ef19: packaging: delete unnecessary updating of `dirs` list
rHGa102f61a917e: packaging: delete unnecessary updating of `dirs` list

Summary

The dirs list is not used and it seems it also wasn't used when this
code was added in 395b0e132836 (Don't copy hidden files/directories
during setup.py install, 2009-07-14).

Diff Detail

Repository

rHG Mercurial

Branch

default

Lint

No Linters Available

Unit

No Unit Test Coverage

Event Timeline

martinvonz created this revision.Jul 31 2020, 7:59 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJul 31 2020, 7:59 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

martinvonz added a child revision: D8858: packaging: include templates with their package as key in package_data.Jul 31 2020, 7:59 PM

indygreg accepted this revision.Aug 2 2020, 12:29 PM

This revision is now accepted and ready to land.Aug 2 2020, 12:29 PM

martinvonz added a commit: rHGa102f61a917e: packaging: delete unnecessary updating of `dirs` list.Aug 2 2020, 12:34 PM

Closed by commit rHGa102f61a917e: packaging: delete unnecessary updating of `dirs` list (authored by martinvonz). · Explain Why

This revision was automatically updated to reflect the committed changes.

martinvonz added a commit: rHGc8655782ef19: packaging: delete unnecessary updating of `dirs` list.Aug 2 2020, 1:42 PM

martinvonz removed a child revision: D8858: packaging: include templates with their package as key in package_data.Aug 4 2020, 2:59 AM

Revision Contents
Changeset List

			Path	Packages
M			setup.py (1 line)

Commit	Parents	Author	Summary	Date
6b376272490c	a38620371b36	Martin von Zweigbergk		Jul 31 2020, 1:49 AM

Status	Author	Revision
Closed	martinvonz	D8901 hgweb: enable reading styles from resources in frozen binaries
Closed	martinvonz	D8900 hgweb: rely on open_template()'s fallback to using templatedir()
Closed	martinvonz	D8899 hgweb: open mapfile using templater.open_template()
Closed	martinvonz	D8898 hgweb: simplify a constant-length list by converting to literal tuple
Closed	martinvonz	D8897 hgweb: remove some accesses to private member uimod._unset
Closed	martinvonz	D8896 templater: try to read %include in mapfiles from resources
Closed	martinvonz	D8895 templater: unroll loop over mapfile directories
Closed	martinvonz	D8894 templater: make open_template() read from resources if in frozen binary
Closed	martinvonz	D8893 templater: pass opened file-like object to templatespec
Closed	martinvonz	D8892 templater: replace templatepath() with function that also opens the file
Closed	martinvonz	D8891 templater: start passing resource to read from into _readmapfile()
Closed	martinvonz	D8890 templater: move stylemap() to hgweb_mod, since that's its only user
Closed	martinvonz	D8874 hgweb: simplify staticfile() now that we always pass it a single directory
Closed	martinvonz	D8858 packaging: include templates with their package as key in package_data
Abandoned	martinvonz	D8809 templater: reuse check for both "map-cmdline.<name>" and "<name>"
Closed	martinvonz	D8857 packaging: delete unnecessary updating of `dirs` list
Closed	martinvonz	D8856 packaging: make "mercurial.defaultrc" a key in package_data
Closed	martinvonz	D8855 packaging: mark mercurial.templates and subdirs as packages
Closed	martinvonz	D8854 templates: add __init__.py files to templates/ dirs
Closed	martinvonz	D8853 templatespec: use new factory functions in hooklib
Closed	martinvonz	D8848 templatespec: use new factory functions in logcmdutil
Closed	martinvonz	D8847 templatespec: move check for non-unicode to lower-level function
Closed	martinvonz	D8846 templatespec: logcmdutil.templatespec() gets either template or mapfile
Closed	martinvonz	D8845 templatespec: create a factory function for each type there is
Closed	martinvonz	D8844 templater: stop accepting a single style to stylemap()
Closed	martinvonz	D8807 formatter: inline a variable assigned from `templater.templater.frommapfile`
Closed	martinvonz	D8806 templater: don't normalize path separators to '/' when interacting with OS
Closed	martinvonz	D8805 formatter: remove now-unnecessary check for file-ness
Closed	martinvonz	D8804 templater: make templatepath() not return directory paths
Closed	martinvonz	D8803 tests: show unusual error message for `hg log --style coal`
Closed	martinvonz	D8796 config: remove now-unused `abs` argument from `include` callback
Closed	martinvonz	D8795 config: re-calculate absolute %include path in `include` callback
Closed	martinvonz	D8794 subrepoutil: use relative path for looking up config `%include`s
Closed	martinvonz	D8793 config: remove now-unused support for "includepaths"
Closed	martinvonz	D8800 tests: add tests trying to use dir as style, as %include, and as __base__
Closed	martinvonz	D8802 tests: fix mistaken copy&paste from commit 4489e9a22763

Diff 22167

setup.py


	def ordinarypath(p):			def ordinarypath(p):
	return p and p[0] != '.' and p[-1] != '~'			return p and p[0] != '.' and p[-1] != '~'


	for root in ('templates',):			for root in ('templates',):
	for curdir, dirs, files in os.walk(os.path.join('mercurial', root)):			for curdir, dirs, files in os.walk(os.path.join('mercurial', root)):
	curdir = curdir.split(os.sep, 1)[1]			curdir = curdir.split(os.sep, 1)[1]
	dirs[:] = filter(ordinarypath, dirs)
	for f in filter(ordinarypath, files):			for f in filter(ordinarypath, files):
	f = os.path.join(curdir, f)			f = os.path.join(curdir, f)
	packagedata['mercurial'].append(f)			packagedata['mercurial'].append(f)

	datafiles = []			datafiles = []

	# distutils expects version to be str/unicode. Converting it to			# distutils expects version to be str/unicode. Converting it to
	# unicode on Python 2 still works because it won't contain any			# unicode on Python 2 still works because it won't contain any

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	22167		Jul 31 2020, 7:59 PM	★	★
Diff 2	22192	rHGa102f61a917e59e224ec2bc2f784c67a4a052627	Jul 31 2020, 1:49 AM	★	★