This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8857

packaging: delete unnecessary updating of `dirs` list
ClosedPublic

Authored by martinvonz on Jul 31 2020, 7:59 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGc8655782ef19: packaging: delete unnecessary updating of `dirs` list
rHGa102f61a917e: packaging: delete unnecessary updating of `dirs` list
Summary

The dirs list is not used and it seems it also wasn't used when this
code was added in 395b0e132836 (Don't copy hidden files/directories
during setup.py install, 2009-07-14).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Msetup.py (1 line)

Diff 22192

setup.py

def ordinarypath(p): def ordinarypath(p):
return p and p[0] != '.' and p[-1] != '~' return p and p[0] != '.' and p[-1] != '~'
for root in ('templates',): for root in ('templates',):
for curdir, dirs, files in os.walk(os.path.join('mercurial', root)): for curdir, dirs, files in os.walk(os.path.join('mercurial', root)):
curdir = curdir.split(os.sep, 1)[1] curdir = curdir.split(os.sep, 1)[1]
dirs[:] = filter(ordinarypath, dirs)
for f in filter(ordinarypath, files): for f in filter(ordinarypath, files):
f = os.path.join(curdir, f) f = os.path.join(curdir, f)
packagedata['mercurial'].append(f) packagedata['mercurial'].append(f)
datafiles = [] datafiles = []
# distutils expects version to be str/unicode. Converting it to # distutils expects version to be str/unicode. Converting it to
# unicode on Python 2 still works because it won't contain any # unicode on Python 2 still works because it won't contain any