This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8957

hg-core: fix some `clippy` warnings
ClosedPublic

Authored by acezar on Aug 26 2020, 9:23 AM.

Details

Reviewers
marmoute
Alphare
pulkit
Group Reviewers
hg-reviewers
Commits
rHG3d9f1dfc52c2: hg-core: fix some `clippy` warnings

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

acezar created this revision.Aug 26 2020, 9:23 AM
acezar retitled this revision from hg-core: fix some clippy warnings to hg-core: fix some `clippy` warnings.Aug 26 2020, 9:44 AM
marmoute accepted this revision.Aug 26 2020, 3:24 PM
marmoute added a subscriber: marmoute.

Same here, this could have been two distinct commit. But this is small enough.

Alphare accepted this revision.Aug 28 2020, 4:24 AM
pulkit accepted this revision.Sep 11 2020, 5:06 AM
This revision is now accepted and ready to land.Sep 11 2020, 5:06 AM
acezar added a commit: rHG3d9f1dfc52c2: hg-core: fix some `clippy` warnings.Sep 11 2020, 5:47 AM
Closed by commit rHG3d9f1dfc52c2: hg-core: fix some `clippy` warnings (authored by acezar). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 22624

rust/hg-core/src/operations/find_root.rs

Err(FindRootError { Err(FindRootError {
kind: FindRootErrorKind::GetCurrentDirError(e), kind: FindRootErrorKind::GetCurrentDirError(e),
}) })
})?, })?,
Some(path) => path.into(), Some(path) => path.into(),
}; };
if current_dir.join(".hg").exists() { if current_dir.join(".hg").exists() {
return Ok(current_dir.into()); return Ok(current_dir);
} }
let mut ancestors = current_dir.ancestors(); let ancestors = current_dir.ancestors();
while let Some(parent) = ancestors.next() { for parent in ancestors {
if parent.join(".hg").exists() { if parent.join(".hg").exists() {
return Ok(parent.into()); return Ok(parent.into());
} }
} }
Err(FindRootError { Err(FindRootError {
kind: FindRootErrorKind::RootNotFound(current_dir.to_path_buf()), kind: FindRootErrorKind::RootNotFound(current_dir.to_path_buf()),
}) })
} }